Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all owned NPCs together with player on Team Switching #789

Merged
merged 7 commits into from
Apr 12, 2024

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Feb 5, 2024

I am aware of #721 existence and also address #649, however on doing tests with the PvP glitch in Frontier Defense, the problem of player switching teams does not lie only on Hacked Spectres, the player's own Auto-Titan will not switch, as well whatever Turrets they placed or Ticks they tossed.

This is my approach to fixing all those issue in one go, while also including a missing feature from Respawn's code that notify when players switches teams.

@Zanieon Zanieon linked an issue Feb 5, 2024 that may be closed by this pull request
@Zanieon Zanieon added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Feb 7, 2024
Copy link
Member

@catornot catornot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked in a test server and I approve of the code :)

altought this pr won't work if the team is set directly :trollface:

live footage of this working :

output.mp4

github is mean so I set the bitrate of the video to 100k >:(

@Zanieon Zanieon added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Mar 29, 2024
@GeckoEidechse
Copy link
Member

Merging based on previous review.
(although technically this didn't get proper code review but oh well ig)

@GeckoEidechse GeckoEidechse merged commit 9661372 into R2Northstar:main Apr 12, 2024
3 checks passed
@Zanieon Zanieon deleted the player_team_switch branch April 13, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Hacked spectres causing a server crash in Attrition
3 participants