Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change response when no errors found #48

Closed
wants to merge 5 commits into from

Conversation

Bobbyperson
Copy link

The old message implies that an error occurred while reading the log. This is clearer.

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure if this solves the problem or just further hides as we only hit this part when we set problem_found to true but then set nothing in the embed.

Which tbh should never happen in the first place ^^"

If there were no issues with the log, we'd never hit this part in the first place.

@Bobbyperson
Copy link
Author

Wait is that actually what's happening? I need to look into this deeper

@GeckoEidechse GeckoEidechse marked this pull request as draft August 27, 2024 12:38
@Bobbyperson
Copy link
Author

I think it has something to do with duplicate audio checking???? maybe????? I'm being held back by not knowing what the hell most of this code is doing, I might rewrite the audio aspect since it seems to be a bit dubious anyways.

@GeckoEidechse
Copy link
Member

Tbh, might just be worth rewriting the log parsing first with a focus on regex or something as mentioned in #58 before attempting to fix the current spaghetti logic.

@Bobbyperson Bobbyperson closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants