fix: array type template (twilio#50)

RJPearson94 · Jun 4, 2021 · 3ed5c3a · 3ed5c3a
1 parent 931d872
commit 3ed5c3a
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/examples/go/test/unit_test.go b/examples/go/test/unit_test.go
@@ -131,3 +131,34 @@ func TestQueryParams(t *testing.T) {
 	twilio := openapi.NewDefaultApiServiceWithClient(testClient)
 	twilio.ListCallRecording("CA1234", &params)
 }
+
+func TestArrayTypeParam(t *testing.T) {
+	callbackEvents := []string{"http://test1.com/", "http://test2.com"}
+	params := openapi.CreateCallRecordingParams{
+		RecordingStatusCallbackEvent: &callbackEvents,
+	}
+
+	expectedData := url.Values{}
+	for _, item := range callbackEvents {
+		expectedData.Add("RecordingStatusCallbackEvent", item)
+	}
+
+	mockCtrl := gomock.NewController(t)
+	testClient := NewMockBaseClient(mockCtrl)
+	testClient.EXPECT().AccountSid().DoAndReturn(func() string {
+		return accountSid
+	})
+	testClient.EXPECT().SendRequest(
+		gomock.Any(),
+		gomock.Any(),
+		gomock.Any(),
+		gomock.Any()).
+		DoAndReturn(func(method string, rawURL string, data url.Values,
+			headers map[string]interface{}) (*http.Response, error) {
+			assert.Equal(t, data, expectedData)
+			return &http.Response{Body: ioutil.NopCloser(bytes.NewReader(nil))}, nil
+		},
+		)
+	twilio := openapi.NewDefaultApiServiceWithClient(testClient)
+	twilio.CreateCallRecording("CA1234", &params)
+}
diff --git a/src/main/resources/twilio-go/api.mustache b/src/main/resources/twilio-go/api.mustache
@@ -84,7 +84,14 @@ func (c *{{{classname}}}Service) {{{nickname}}}({{#allParams}}{{#required}}{{par
 	data.Set("{{{baseName}}}", string(v))
 {{/isFreeFormObject}}
 {{^isFreeFormObject}}
-    data.Set("{{{baseName}}}", {{^isArray}}{{^isString}}fmt.Sprint({{/isString}}{{#isDateTime}}({{/isDateTime}}*params.{{paramName}}{{^isString}}{{#isDateTime}}).Format(time.RFC3339){{/isDateTime}}){{/isString}}){{/isArray}} {{#isArray}}strings.Join(*params.{{paramName}}, ",")){{/isArray}}
+    {{#isArray}}
+        for _, item  := range *params.{{paramName}} {
+            data.Add("{{{baseName}}}", item)
+        }
+    {{/isArray}}
+    {{^isArray}}
+        data.Set("{{{baseName}}}", {{^isString}}fmt.Sprint({{/isString}}{{#isDateTime}}({{/isDateTime}}*params.{{paramName}}{{^isString}}{{#isDateTime}}).Format(time.RFC3339){{/isDateTime}}){{/isString}})
+    {{/isArray}}
 {{/isFreeFormObject}}
 }
 {{/isHeaderParam}}