Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for audits #220

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Add support for audits #220

merged 3 commits into from
Jan 15, 2025

Conversation

bcspragu
Copy link
Collaborator

This PR adds all the stuff needed for running audits:

  • Updating the runner_base image to the newest version
  • Interfacing with the run_audit.sh script
  • Assorted UX tweaks
    • Mostly because I don't think there's anything to 'View' like for Reports and Dashboards, so we just offer the download button
    • Also hide the download button for not-completed runs

This PR adds all the stuff needed for running audits:
- Updating the `runner_base` image to the newest version
- Interfacing with the `run_audit.sh` script
- Assorted UX tweaks
  - Mostly because I don't think there's anything to 'View' like for Reports and Dashboards, so we just offer the download button
  - Also hide the download button for not-completed runs
@bcspragu bcspragu requested a review from gbdubs December 29, 2024 03:43
- Define some i18n strings
- Only download the `audit_file.csv` for audits
- Show/hide download/view buttons when it makes sense
- Add some stragging env vars
@bcspragu bcspragu merged commit 6c542ef into main Jan 15, 2025
2 checks passed
@bcspragu bcspragu deleted the brandon/audit-support branch January 15, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant