Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logic #87

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix logic #87

merged 1 commit into from
Apr 9, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Apr 9, 2024

No description provided.

@cjyetman cjyetman requested a review from jdhoffa April 9, 2024 07:13
Copy link

github-actions bot commented Apr 9, 2024

Coverage Report
file head main diff
Overall 63% 63% 0%
R/canonize_path.R 91% 91% 0%
R/char_to_.R 0% 0% 0%
R/determine_header_types.R 92% 92% 0%
R/determine_headers.R 87% 87% 0%
R/get_csv_specs.R 0% 0% 0%
R/guess_delimiter.R 100% 100% 0%
R/guess_file_encoding.R 89% 89% 0%
R/guess_numerical_mark.R 94% 94% 0%
R/has_binary_null.R 100% 100% 0%
R/has_consistent_fields_per_line.R 100% 100% 0%
R/has_header.R 89% 89% 0%
R/has_newline_at_end.R 100% 100% 0%
R/is_file_accessible.R 100% 100% 0%
R/is_readable_file.R 100% 100% 0%
R/is_text_file.R 100% 100% 0%
R/is_valid_currency_code.R 100% 100% 0%
R/is_valid_cusip.R 100% 100% 0%
R/is_valid_isin.R 100% 100% 0%
R/read_first_line.R 88% 88% 0%
R/read_portfolio_csv.R 91% 91% 0%
R/simplify_if_one_col_df.R 100% 100% 0%

Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like great logic. the best!

Copy link
Collaborator

@AlexAxthelm AlexAxthelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me.

@cjyetman cjyetman added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit 323a73e Apr 9, 2024
10 checks passed
@cjyetman cjyetman deleted the cjyetman-patch-1 branch April 9, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants