Skip to content

Commit

Permalink
Update to svd2rust 0.33.1
Browse files Browse the repository at this point in the history
This improves the generated API in various minor ways.  We cannot
guarantee full backwards compatibility for downstream users but the
changes should not be too disrupting.

Most importantly, upstream svd2rust switched to a different case style
for identifiers in 0.32.0.  For now, this is disabled using
`--ident-formats legacy` but we should consider following their
suggestion at some point in the future.
  • Loading branch information
Rahix committed May 4, 2024
1 parent fa5aef2 commit 96b60da
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
uses: actions-rs/[email protected]
with:
crate: svd2rust
version: 0.28.0
version: 0.33.1
- name: Install cargo-form
if: steps.cache-cargo.outputs.cache-hit != 'true'
uses: actions-rs/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ svd/%.svd.patched: svd/%.svd .deps/%.d
src/devices/%/mod.full.rs: svd/%.svd.patched
@mkdir -p $(@D)
@echo -e "\tSVD2RUST\t$*"
@cd $(@D); svd2rust --generic_mod --make_mod --target none -i $(realpath $<)
@cd $(@D); svd2rust --ident-formats-theme legacy --generic_mod --make_mod --target none -i $(realpath $<)
@mv $(@D)/mod.rs $@
@mv $(@D)/generic.rs $(@D)/../../generic.rs

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ The version on `crates.io` is pre-built. The following is only necessary when t
You need to have [atdf2svd][] (= 0.4.0), [svd2rust][] (= 0.28), [form][] (>= 0.8), [rustfmt][](for the *nightly* toolchain) and [svdtools][] (>= 0.1.9) installed:
```bash
cargo install atdf2svd --version 0.4.0
cargo install svd2rust --version 0.28.0
cargo install svd2rust --version 0.33.1
cargo install form
rustup component add --toolchain nightly rustfmt
pip3 install --user svdtools
Expand Down

0 comments on commit 96b60da

Please sign in to comment.