feat: add support for Sparkfun ProMini 3.3V 8Mhz (sparkfun-promini-3v3) #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippfehlr
force-pushed
the
sparkfun-promini-3.3v
branch
from
58d8616 to
b01a201
Compare
|
@stappersg You linked to this PR, not #445, which I assume you meant. True, I didn’t check for existing PRs. However, because this is mergeable as is, I’ll leave it open. #445 (comment): As I understand this the ProMini 3.3V is an Arduino (328P) clocked down, meaning it is only appropriate to handle it as such. |
tippfehlr
changed the title
Rahix
force-pushed
the
sparkfun-promini-3.3v
branch
from
c232cd1 to
2aa76a9
Compare
Rahix
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the ProMini 3.3V (8Mhz) (
sparkfun-promini-3v3).Apart from
arduino-hal/src/clock.rsit is entirely copied from #435.Becausesparkfun-promini-3.3vis not a valid name, I left out the.3.Another option would be to rename both the 5V and the 3.3V version to 16Mhz and 8Mhz respectively, eg.-sparkfun-promini-16mhz-sparkfun-promini-8mhzBoth variants are fine in my opinion, however renaming5vto16mhzwould be a breaking change.Original issue: #425