Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Support for Flutter 3.22 #1921

Merged
merged 9 commits into from
Jun 24, 2024
Merged

build: Support for Flutter 3.22 #1921

merged 9 commits into from
Jun 24, 2024

Conversation

validcube
Copy link
Member

@validcube validcube commented May 28, 2024

This lock Flutter to v3.22, Android SDK compile to 34, and also added desugaring because one of our dependency now depend on them

@validcube validcube changed the base branch from main to dev May 28, 2024 15:35
@validcube validcube marked this pull request as draft May 28, 2024 15:37
@kitadai31
Copy link
Contributor

You don't need desugaring if minSdk is 26+

@validcube validcube changed the title build: Introduce lock to Flutter, Android SDK, NDK build: Support for Flutter 3.22 Jun 15, 2024
@validcube
Copy link
Member Author

@kitadai31 You don't need desugaring if minSdk is 26+

For this one, I'm not sure (and I'm currently not in a capacity where I am comfortable investigating further because I'm currently super busy at the moment), upon compiling ReVanced Manager without desugaring lib an error will occured.

image

@validcube validcube marked this pull request as ready for review June 15, 2024 10:43
@kitadai31
Copy link
Contributor

@kitadai31 You don't need desugaring if minSdk is 26+

For this one, I'm not sure (and I'm currently not in a capacity where I am comfortable investigating further because I'm currently super busy at the moment), upon compiling ReVanced Manager without desugaring lib an error will occured.

image

What ☠
I understood, sorry

@validcube validcube merged commit 73368b5 into dev Jun 24, 2024
2 checks passed
@validcube validcube deleted the lock branch July 26, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants