Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add web3 wallet #15

Merged
merged 9 commits into from
Nov 12, 2023
Merged

Feature: add web3 wallet #15

merged 9 commits into from
Nov 12, 2023

Conversation

NandyBa
Copy link
Member

@NandyBa NandyBa commented Sep 17, 2023

No description provided.

@NandyBa NandyBa requested a review from Sigri44 September 17, 2023 11:56
@NandyBa NandyBa linked an issue Sep 17, 2023 that may be closed by this pull request
@NandyBa NandyBa force-pushed the feature/add-web3-wallet branch 2 times, most recently from 796442b to 9c2dcca Compare September 17, 2023 13:06
@NandyBa NandyBa force-pushed the feature/add-web3-wallet branch 2 times, most recently from efcf4ab to b3aa858 Compare September 30, 2023 21:32
@NandyBa NandyBa removed the request for review from Sigri44 November 1, 2023 11:53
@NandyBa
Copy link
Member Author

NandyBa commented Nov 1, 2023

The wallet connection works correctly and works with multiple wallets thanks to @jeanbenoit-richez.
The small issue is that updated header don't contain the SettingsMenu component. SettingsMenu component itself contain CurrencySelect who is essential to dashboard display.

Dashboard run using last commit (wallet logged)
Capture d’écran 2023-11-01 à 12 58 30

@NandyBa NandyBa force-pushed the feature/add-web3-wallet branch from 7dbfc03 to 443e39d Compare November 1, 2023 13:03
@NandyBa
Copy link
Member Author

NandyBa commented Nov 1, 2023

I have fixed the issue and keep your alternative version on the feature/add-web3-wallet-alternative-version branch

@NandyBa
Copy link
Member Author

NandyBa commented Nov 1, 2023

The connectors have been added the only issue is that walletConnect modal go under the wallet modal

@jycssu-com jycssu-com self-requested a review November 12, 2023 15:48
@jycssu-com jycssu-com merged commit 228c2f6 into develop Nov 12, 2023
1 check passed
@jycssu-com jycssu-com deleted the feature/add-web3-wallet branch November 12, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add connexion via Web3 wallet
2 participants