Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add product type filter #94

Merged
merged 8 commits into from
Dec 21, 2024
Merged

Conversation

NandyBa
Copy link
Member

@NandyBa NandyBa commented Dec 15, 2024

Address request #92
Feature: Add Token Filtering by Product Type

This PR introduces the ability for users to filter tokens by their productType. The filtering functionality enhances the user experience by allowing users to narrow down token views based on specific categories.

Details:

  • Supported productType values with examples:
    • all: Displays all tokens (e.g., *).
    • real_estate_rental: Filters tokens related to rental properties (e.g., 9943 Marlowe St, Detroit, MI 48227).
    • equity_token: Filters tokens representing equity holdings (e.g., RWA Holdings, Neuchatel, NE, Suisse).
    • loan_income: Filters tokens related to income from loans (e.g., LOAN 18 Bristol Villa Buenaventura, El Chiru, Cocle, Panama).

This feature was requested by @Baptiste-Yucca in #92

Note as Equity tokens all been part of other assets section. Selection of equity token filter automatically switch them on

@NandyBa NandyBa requested a review from BenoistP December 15, 2024 20:35
BenoistP
BenoistP previously approved these changes Dec 17, 2024
Copy link
Collaborator

@BenoistP BenoistP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
There's a strange behaviour which occurs when unchecking a previously checked value: it filters out everything.
But it exists on all filters and this is beyond the scope of thisPpR

@NandyBa NandyBa requested a review from BenoistP December 17, 2024 20:00
@NandyBa
Copy link
Member Author

NandyBa commented Dec 17, 2024

Looks good to me. There's a strange behaviour which occurs when unchecking a previously checked value: it filters out everything. But it exists on all filters and this is beyond the scope of thisPpR

It's fixed by #95

Copy link
Collaborator

@BenoistP BenoistP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@NandyBa NandyBa merged commit d31c2ab into develop Dec 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants