Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update btmysql.php #101

Conversation

deepend-tildeclub
Copy link
Contributor

fixes some variable errors. But also fixes some issues the page was having saving information in some text boxes. For example if I remember correctly you'd go set a category name and instead of the words you put it would put a 0.

deepend-tildeclub and others added 2 commits January 23, 2024 20:03
fixes some variable errors. But also fixes some issues the page was having saving information in some text boxes.   For example if I remember correctly you'd go set a category name and instead of the words you put it would put a 0.
@RedDragonWebDesign
Copy link
Owner

For example if I remember correctly you'd go set a category name and instead of the words you put it would put a 0.

What page/form should I use to test this?

@deepend-tildeclub
Copy link
Contributor Author

For example if I remember correctly you'd go set a category name and instead of the words you put it would put a 0.

What page/form should I use to test this?

Couldn't remember when I submitted.. but realized it when I was working on the next one.. It was a few places but the place I remember for sure was when naming a world clock it would put a number instead of the name that you specified.

Also think naming / renaming forum categories. Sorry my memory sucks. the delay from the original fix and me fixing all my other git mishaps makes things a bit foggy.

@RedDragonWebDesign
Copy link
Owner

Unable to reproduce on the add clock, edit clock, add forum category, or edit forum category pages using the string "Test". Each time the thing was successfully edited. Can you git checkout master and find me a steps to reproduce please?

@deepend-tildeclub
Copy link
Contributor Author

Unable to reproduce on the add clock, edit clock, add forum category, or edit forum category pages using the string "Test". Each time the thing was successfully edited. Can you git checkout master and find me a steps to reproduce please?

Sorry my memory sucks.. Found what the error was originally. you can find it by trying to add a menu item. and you'll get an error:

Fatal error: Uncaught ArgumentCountError: mysqli_stmt::bind_param() does not accept unknown named parameters in /home/retrodig/public_html/zarksfallenangels/classes/btmysql.php:105 Stack trace: #0 /home/retrodig/public_html/zarksfallenangels/classes/btmysql.php(105): mysqli_stmt->bind_param() #1 /home/retrodig/public_html/zarksfallenangels/classes/basic.php(178): btMySQL->bindParams() #2 /home/retrodig/public_html/zarksfallenangels/members/include/admin/managemenu/include/downloadoptions.php(5): Basic->get_entries() #3 /home/retrodig/public_html/zarksfallenangels/members/include/admin/addmenuitem.php(114): require_once('...') #4 /home/retrodig/public_html/zarksfallenangels/members/console.php(154): require_once('...') #5 {main} thrown in /home/retrodig/public_html/zarksfallenangels/classes/btmysql.php on line 105

@deepend-tildeclub
Copy link
Contributor Author

were you able to reproduce it since my last message? Or is there other issues with this code? :) Just wondering so I can avoid having to put this fix in place each time I run a fresh copy from master.

@RedDragonWebDesign
Copy link
Owner

Will test this one a bit more later then approve. No more changes needed. I have some ideas for more changes, but will save for a future patch :)

@deepend-tildeclub
Copy link
Contributor Author

Will test this one a bit more later then approve. No more changes needed. I have some ideas for more changes, but will save for a future patch :)

Nice.. Thanks for all your effort considering your lack of time. Much appreciated. I will be getting back to finding issues this evening. Been a busy day so far :) Going to also put some more effort into setting up a better dev environment.. My current setup is barely functional.

@RedDragonWebDesign RedDragonWebDesign merged commit 561bbc2 into RedDragonWebDesign:master Jan 26, 2024
1 of 2 checks passed
@deepend-tildeclub deepend-tildeclub deleted the fix-variable-errors-in-classes/btmysql.php branch February 1, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants