always show columns in inspector and table

Renumics · Oct 9, 2023 · ad015e3 · ad015e3
1 parent 8eb4e90
commit ad015e3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/src/widgets/DataGrid/DataGrid.tsx b/src/widgets/DataGrid/DataGrid.tsx
@@ -35,13 +35,13 @@ const DataGrid: Widget = () => {
 
     const [scrollbarWidth] = getScrollbarSize();
 
-    const defaultVisibleColumnKeys = useMemo(
-        () =>
-            allColumns
-                .filter((column) => columnVisibleByDefault(column))
-                .map(({ key }) => key),
-        [allColumns]
-    );
+    const defaultVisibleColumnKeys = useMemo(() => {
+        const visibleColumnKeys = allColumns
+            .filter((column) => columnVisibleByDefault(column))
+            .map(({ key }) => key);
+        if (visibleColumnKeys.length) return visibleColumnKeys;
+        return allColumns.filter((col) => !col.hidden).map(({ key }) => key);
+    }, [allColumns]);
 
     const [tableView, setTableView] = useWidgetConfig<TableView>('tableView', 'full');
     const [visibleColumns, setVisibleColumns] = useWidgetConfig<string[]>(

diff --git a/src/widgets/Inspector/store.tsx b/src/widgets/Inspector/store.tsx
@@ -64,7 +64,11 @@ const StoreProvider = ({ children }: ProviderProps): JSX.Element => {
     const allColumns = useDataset((d) => d.columns);
     const lenses = useComponentsStore((d) => d.lensesByKey);
     const defaultLenses = useMemo(() => {
-        const defaultColumns = allColumns.filter((c) => c.type.binary && !c.hidden);
+        const visibleColumns = allColumns.filter(
+            (c) => !c.hidden && c.type.kind !== 'Embedding'
+        );
+        const binaryColumns = visibleColumns.filter((c) => c.type.binary);
+        const defaultColumns = binaryColumns.length ? binaryColumns : visibleColumns;
         return _.compact(
             defaultColumns.map((column) => {
                 const lens = Object.values(lenses).filter((lens) =>