Merge pull request #258 from Renumics/feature/no-default-histogram-fo…

…r-string-cols dont show strings and ints by default in hist
Renumics · Oct 9, 2023 · d3b38aa · d3b38aa
2 parents 3086976 + efe3535
commit d3b38aa
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/src/widgets/Histogram/Histogram.tsx b/src/widgets/Histogram/Histogram.tsx
@@ -27,6 +27,7 @@ import Info from '../../components/ui/Info';
 const columnsSelector = (d: Dataset) => d.columns;
 
 const validTypes = ['Category', 'str', 'bool', 'int', 'float'];
+const defaultTypes = ['Category', 'bool', 'float'];
 
 const Histogram: Widget = () => {
     const wrapper = useRef<HTMLDivElement>(null);
@@ -39,12 +40,21 @@ const Histogram: Widget = () => {
                 .map((col) => col.key),
         [columns]
     );
+    const defaultColumnKey = useMemo(
+        () =>
+            columns
+                .filter(
+                    (col) => !col.isInternal && defaultTypes.includes(col.type.kind)
+                )
+                .map((col) => col.key)[0],
+        [columns]
+    );
 
     const [filter, setFilter] = useWidgetConfig('filter', false);
 
     const [_columnKey, setColumnKey] = useWidgetConfig<string | undefined>(
         'columnKey',
-        columnKeys[0]
+        defaultColumnKey
     );
 
     const columnKey =