-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3.4.0. Attribution v2 and nonSubscriptionTransactions #174
Merged
Merged
Changes from 20 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
71eb8e9
updates to latest version of react native
vegaro 6a15075
aways embed swift standard library
vegaro 59f0862
Revert "aways embed swift standard library"
vegaro e95878a
removes snapshot repositories
vegaro 3652641
changes location of yarn caches
vegaro ef297e8
importsNotUsedAsValues doesnt work
vegaro 77b3c1b
makes npm more lean
vegaro 7c4c077
version updates
vegaro 856ae4e
adds new attribution functions
vegaro 33d7cf8
adds ios functions to plugin
vegaro c0635e6
fixes indentation
vegaro 78aa430
increases version
vegaro 5291759
adds new functions
vegaro 57999d3
adds example icon
vegaro 6ca5ac1
increases example version
vegaro 0009a0c
updates lock
vegaro de05bfe
fixes bug
vegaro 31b8c76
yarn cache
vegaro 4e32867
broken cache
vegaro 3f0b42e
increases common version
vegaro cf2bd28
PR commnets
vegaro d612b40
upgrade common files
vegaro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -268,12 +268,13 @@ | |
buildSettings = { | ||
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | ||
CLANG_ENABLE_MODULES = YES; | ||
CURRENT_PROJECT_VERSION = 1; | ||
CURRENT_PROJECT_VERSION = 4; | ||
DEAD_CODE_STRIPPING = NO; | ||
DEVELOPMENT_TEAM = 8SXR2327BM; | ||
ENABLE_BITCODE = NO; | ||
INFOPLIST_FILE = ReactNativeSample/Info.plist; | ||
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; | ||
MARKETING_VERSION = 4.0; | ||
OTHER_CFLAGS = ( | ||
"$(inherited)", | ||
"-DFB_SONARKIT_ENABLED=1", | ||
|
@@ -298,10 +299,11 @@ | |
buildSettings = { | ||
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | ||
CLANG_ENABLE_MODULES = YES; | ||
CURRENT_PROJECT_VERSION = 1; | ||
CURRENT_PROJECT_VERSION = 4; | ||
DEVELOPMENT_TEAM = 8SXR2327BM; | ||
INFOPLIST_FILE = ReactNativeSample/Info.plist; | ||
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; | ||
MARKETING_VERSION = 4.0; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I increased the version when validating. I can rollback if necessary, but I don't think it hurts |
||
OTHER_CFLAGS = ( | ||
"$(inherited)", | ||
"-DFB_SONARKIT_ENABLED=1", | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step is failing, still don't know why. I have tried by using
/tmp/yarn
and./tmp/yarn
with the same results.The orb has an open issue about it, so I will monitor and see if they fix it react-native-community/react-native-circleci-orb#66, until the, I think we can live without the caches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add a comment and a link to react-native-community/react-native-circleci-orb#66 to the code here, so that when we look back at it we understand why it's commented and we check if it has been fixed