Delete SQS message if unmarshalling fails (#504)

* Delete SQS message if unmarshalling fails * Fix failing unit test
RichardKnop · Dec 22, 2019 · 93dc9ee · 93dc9ee
1 parent 7a7f434
commit 93dc9ee
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/v1/brokers/sqs/sqs.go b/v1/brokers/sqs/sqs.go
@@ -205,6 +205,10 @@ func (b *Broker) consumeOne(delivery *awssqs.ReceiveMessageOutput, taskProcessor
 	decoder.UseNumber()
 	if err := decoder.Decode(sig); err != nil {
 		log.ERROR.Printf("unmarshal error. the delivery is %v", delivery)
+		// if the unmarshal fails, remove the delivery from the queue
+		if delErr := b.deleteOne(delivery); delErr != nil {
+			log.ERROR.Printf("error when deleting the delivery. delivery is %v, Error=%s", delivery, delErr)
+		}
 		return err
 	}
 	if delivery.Messages[0].ReceiptHandle != nil {