Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new extension: power chatgpt, bring chatgpt into the roam #529

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dragonforce2010
Copy link
Contributor

…l to make our work more efficient!

@github-actions
Copy link

Here’s your link to the diff:

Added dragonforce2010/roam-power-chatgpt d53299d

@github-actions
Copy link

Here’s your link to the diff:

Added dragonforce2010/roam-power-chatgpt 9eaa759

@github-actions
Copy link

Here’s your link to the diff:

Added dragonforce2010/roam-power-chatgpt 2383a38

@panterarocks49
Copy link
Contributor

What is chat-pro-screen and why does it look like compiled code?

@dragonforce2010
Copy link
Contributor Author

What is chat-pro-screen and why does it look like compiled code?

yes, it's compiled code. Let me optimize this pr.

@baibhavbista baibhavbista self-requested a review April 26, 2023 10:28
Copy link
Contributor

@baibhavbista baibhavbista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dragonforce2010

I saw that this extension sends the GPT requests to https://ec2-54-254-24-184.ap-southeast-1.compute.amazonaws.com/ and after that I assume forwards the request to OpenAI.

I'm afraid we cannot approve this extension while it does requests to an unknown backend. If you change it such that it directly does a fetch on openAI's servers, that would make it okay.

Also, as @panterarocks49 already mentioned before, we cannot approve the extension while it has compiled code like src/chat-pro-screen/sdk.js

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

Here’s your link to the diff:

Added dragonforce2010/roam-power-chatgpt 4103abd (PR-shorthand: dragonforce2010+roam-power-chatgpt+529)

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Here’s your link to the diff:

Added dragonforce2010/roam-power-chatgpt c473b45 (PR-shorthand: dragonforce2010+roam-power-chatgpt+529)

@dragonforce2010
Copy link
Contributor Author

Hey @dragonforce2010

I saw that this extension sends the GPT requests to https://ec2-54-254-24-184.ap-southeast-1.compute.amazonaws.com/ and after that I assume forwards the request to OpenAI.

I'm afraid we cannot approve this extension while it does requests to an unknown backend. If you change it such that it directly does a fetch on openAI's servers, that would make it okay.

Also, as @panterarocks49 already mentioned before, we cannot approve the extension while it has compiled code like src/chat-pro-screen/sdk.js

@baibhavbista all the comments have been addressed, please review it, thanks

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Here’s your link to the diff:

Added dragonforce2010/roam-power-chatgpt 8e53481 (PR-shorthand: dragonforce2010+roam-power-chatgpt+529)

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Here’s your link to the diff:

Added dragonforce2010/roam-power-chatgpt e4f79d2 (PR-shorthand: dragonforce2010+roam-power-chatgpt+529)

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Here’s your link to the diff:

Added dragonforce2010/roam-power-chatgpt c5a0da0 (PR-shorthand: dragonforce2010+roam-power-chatgpt+529)

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Here’s your link to the diff:

Added dragonforce2010/roam-power-chatgpt 9cb5e2f (PR-shorthand: dragonforce2010+roam-power-chatgpt+529)

Copy link
Contributor

@baibhavbista baibhavbista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sent some comments via slack @dragonforce2010

@baibhavbista
Copy link
Contributor

Adding my notes for the comments I had here too, for future reference:

  • something weird happened when I ran ./build.sh locally. It produce 100+ js files in the directory

    • image
  • they'd added an API token of their own. Seems to not be working. Since the token is in a public github repo, would not be surprised if a scraping bot found it. Might be a good idea to remove the default API token and force users to use their own key

    • image
  • when sending the "messages" in the chat/completions request, wrong messages are being sent (the first 8 are being sent while the last 8 should be)

    • image
      • here what it’s doing is only keeping the first MaxContentMessageSize messages on each request
        while you probably want to be sending the last MaxContentMessageSize messages
  • I think max_tokens should be customizable. Turns out it was has been hardcoded in the source code to 200. I had been wondering why my requests were getting cut off in the middle

    • image
  • want to use extensionAPI’s addCommand for the "Roam GPT" command instead of the roamAlphaAPI one

    • image
  • nitpick: spelling mistake in “try again”. might be problematic since it is a message sent to openai as well and may give wrong answers

    • image
  • I’d also expect most users of Roam are english users (+ best experience when interacting with chatGPT is in english I think) so maybe placeholder text should be in english as well?

    • image
  • slight nitpick: what about only showing the parts inside triple quotes using codemirror?

    • image
  • another codemirror issue: when a line is highlighted, it’s white by default which is a problem given that font is also mostly white. Compare this with the earlier screenshot

    • image

If I have more comments, will be sending them via slack

@baibhavbista
Copy link
Contributor

@dragonforce2010 reminder that this PR is still in requested changes state

@baibhavbista baibhavbista self-assigned this Apr 22, 2024
@baibhavbista
Copy link
Contributor

Marking this as a "draft PR" in order to not confuse & accidentally release

Please change back to a regular PR after looking at the requested changes @dragonforce2010

@baibhavbista baibhavbista marked this pull request as draft April 24, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants