-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new extension: power chatgpt, bring chatgpt into the roam #529
base: main
Are you sure you want to change the base?
new extension: power chatgpt, bring chatgpt into the roam #529
Conversation
…l to make our work more efficient!
Here’s your link to the diff: |
Here’s your link to the diff: |
Here’s your link to the diff: |
What is chat-pro-screen and why does it look like compiled code? |
yes, it's compiled code. Let me optimize this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dragonforce2010
I saw that this extension sends the GPT requests to https://ec2-54-254-24-184.ap-southeast-1.compute.amazonaws.com/ and after that I assume forwards the request to OpenAI.
I'm afraid we cannot approve this extension while it does requests to an unknown backend. If you change it such that it directly does a fetch on openAI's servers, that would make it okay.
Also, as @panterarocks49 already mentioned before, we cannot approve the extension while it has compiled code like src/chat-pro-screen/sdk.js
Here’s your link to the diff: Added dragonforce2010/roam-power-chatgpt 4103abd (PR-shorthand: |
0fdccd5
to
c75b578
Compare
Here’s your link to the diff: Added dragonforce2010/roam-power-chatgpt c473b45 (PR-shorthand: |
@baibhavbista all the comments have been addressed, please review it, thanks |
c75b578
to
7e9230b
Compare
Here’s your link to the diff: Added dragonforce2010/roam-power-chatgpt 8e53481 (PR-shorthand: |
7e9230b
to
6002c31
Compare
Here’s your link to the diff: Added dragonforce2010/roam-power-chatgpt e4f79d2 (PR-shorthand: |
6002c31
to
5cce425
Compare
Here’s your link to the diff: Added dragonforce2010/roam-power-chatgpt c5a0da0 (PR-shorthand: |
5cce425
to
234d4e9
Compare
Here’s your link to the diff: Added dragonforce2010/roam-power-chatgpt 9cb5e2f (PR-shorthand: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sent some comments via slack @dragonforce2010
Adding my notes for the comments I had here too, for future reference:
If I have more comments, will be sending them via slack |
@dragonforce2010 reminder that this PR is still in requested changes state |
Marking this as a "draft PR" in order to not confuse & accidentally release Please change back to a regular PR after looking at the requested changes @dragonforce2010 |
…l to make our work more efficient!