Fix XSS vulnerability #493
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a Cross-Site Scripting (XSS) vulnerability that would allow an attacker to execute arbitrary JavaScript if they had a way to input data that would ultimately be displayed in a Dropkick select (even if the `<select>` element itself were properly escaped). This was due to a code path that would set the `innerHTML` of a div to the `.text` property of a corresponding option node.text`. If that text value contained valid HTML, the div would be built out with that HTML. This commit instead updates the logic to set `innerHTML` to the `innerHTML` of the option, which would appropriately carry over HTML entities, etc. Here is a fiddle that reproduces the issue: https://jsfiddle.net/L32ej60q/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a Cross-Site Scripting (XSS) vulnerability that would allow an attacker to execute arbitrary JavaScript if they had a way to input data that would ultimately be displayed in a Dropkick select (even if the
<select>element itself were properly escaped). This was due to a code path that would set theinnerHTMLof a div to the.textproperty of a corresponding option node. If that text value contained valid HTML, the div would be built out with that HTML. This commit instead updates the logic to setinnerHTMLto theinnerHTMLof the option, which would appropriately carry over HTML entities, etc.Here is a fiddle that reproduces the issue:
https://jsfiddle.net/L32ej60q/