-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to ESLint v9 #1631
Closed
Closed
Switching to ESLint v9 #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the typescript-eslint group with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser). Updates `@typescript-eslint/eslint-plugin` from 7.2.0 to 7.3.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/eslint-plugin</code>'s releases</a>.</em></p> <blockquote> <h2>v7.3.0</h2> <h2>7.3.0 (2024-03-18)</h2> <h3>🚀 Features</h3> <ul> <li><strong>eslint-plugin:</strong> [restrict-template-expressions] add <code>allowArray</code> option (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8389">#8389</a>)</li> <li><strong>eslint-plugin:</strong> add meta.docs.recommended setting for strict config options (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8364">#8364</a>)</li> <li><strong>eslint-plugin:</strong> add rule <code>use-unknown-in-catch-callback-variables</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8383">#8383</a>)</li> <li><strong>eslint-plugin:</strong> [prefer-reduce-type-parameter] supports tuple, union, intersection (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8642">#8642</a>)</li> <li><strong>eslint-plugin-internal:</strong> add internal lint rule no-relative-paths-to-internal-packages (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8596">#8596</a>)</li> <li><strong>typescript-estree:</strong> disallow switch statements with multiple default cases (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8411">#8411</a>)</li> <li><strong>utils:</strong> add parser name to thrown parser error message (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8484">#8484</a>)</li> </ul> <h3>🩹 Fixes</h3> <ul> <li>correct <code>engines.node</code> constraints in <code>package.json</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8671">#8671</a>)</li> <li><strong>eslint-plugin:</strong> [unbound-method] check method definition in object literal using longhand form (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8637">#8637</a>)</li> <li><strong>eslint-plugin:</strong> [consistent-type-imports] handle imports without specifiers (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8308">#8308</a>)</li> <li><strong>eslint-plugin:</strong> [no-redundant-type-constituents] incorrectly marks & string as redundant (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8282">#8282</a>)</li> <li><strong>eslint-plugin:</strong> [no-unnecessary-qualifier] handle merge namespace with enum (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8591">#8591</a>)</li> <li><strong>eslint-plugin:</strong> [no-unused-expressions] false negatives when using assertions (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8668">#8668</a>)</li> <li><strong>eslint-plugin:</strong> [ban-ts-comment] more accurate handling of multiline comments (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8416">#8416</a>)</li> <li><strong>eslint-plugin:</strong> [explicit-function-return-type, explicit-module-boundary-types] improved checking for allowHigherOrderFunctions option (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8508">#8508</a>)</li> <li><strong>eslint-plugin:</strong> [class-literal-property-style] ignore property assigned in constructor (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8412">#8412</a>)</li> <li><strong>eslint-plugin:</strong> [no-unnecessary-type-assertion] fix false negative for const variable declarations (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8558">#8558</a>)</li> <li><strong>typescript-estree:</strong> fix the issue of single run inferring in the pnpm repo (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/3811">#3811</a>, <a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8702">#8702</a>)</li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Abraham Guo</li> <li>Alexu</li> <li>Arka Pratim Chaudhuri <a href="https://github.com/arka1002"><code>@arka1002</code></a></li> <li>auvred <a href="https://github.com/auvred"><code>@auvred</code></a></li> <li>Derrick Isaacson</li> <li>fnx <a href="https://github.com/DMartens"><code>@DMartens</code></a></li> <li>Josh Goldberg ✨</li> <li>Kirk Waiblinger <a href="https://github.com/kirkwaiblinger"><code>@kirkwaiblinger</code></a></li> <li>Marta Cardoso <a href="https://github.com/up201304504"><code>@up201304504</code></a></li> <li>Michaël De Boey</li> <li>Tristan Rasmussen</li> <li>YeonJuan <a href="https://github.com/yeonjuan"><code>@yeonjuan</code></a></li> </ul> <p>You can read about our <a href="https://main--typescript-eslint.netlify.app/users/versioning">versioning strategy</a> and <a href="https://main--typescript-eslint.netlify.app/users/releases">releases</a> on our website.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md"><code>@typescript-eslint/eslint-plugin</code>'s changelog</a>.</em></p> <blockquote> <h2>7.3.0 (2024-03-18)</h2> <h3>🚀 Features</h3> <ul> <li> <p><strong>eslint-plugin:</strong> [restrict-template-expressions] add <code>allowArray</code> option</p> </li> <li> <p><strong>eslint-plugin:</strong> add meta.docs.recommended setting for strict config options</p> </li> <li> <p><strong>eslint-plugin:</strong> add rule <code>use-unknown-in-catch-callback-variables</code></p> </li> <li> <p><strong>eslint-plugin:</strong> [prefer-reduce-type-parameter] supports tuple, union, intersection</p> </li> </ul> <h3>🩹 Fixes</h3> <ul> <li> <p>correct <code>engines.node</code> constraints in <code>package.json</code></p> </li> <li> <p><strong>eslint-plugin:</strong> [unbound-method] check method definition in object literal using longhand form</p> </li> <li> <p><strong>eslint-plugin:</strong> [consistent-type-imports] handle imports without specifiers</p> </li> <li> <p><strong>eslint-plugin:</strong> [no-redundant-type-constituents] incorrectly marks & string as redundant</p> </li> <li> <p><strong>eslint-plugin:</strong> [no-unnecessary-qualifier] handle merge namespace with enum</p> </li> <li> <p><strong>eslint-plugin:</strong> [no-unused-expressions] false negatives when using assertions</p> </li> <li> <p><strong>eslint-plugin:</strong> [ban-ts-comment] more accurate handling of multiline comments</p> </li> <li> <p><strong>eslint-plugin:</strong> [explicit-function-return-type, explicit-module-boundary-types] improved checking for allowHigherOrderFunctions option</p> </li> <li> <p><strong>eslint-plugin:</strong> [class-literal-property-style] ignore property assigned in constructor</p> </li> <li> <p><strong>eslint-plugin:</strong> [no-unnecessary-type-assertion] fix false negative for const variable declarations</p> </li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Abraham Guo</li> <li>Alexu</li> <li>Arka Pratim Chaudhuri</li> <li>auvred</li> <li>Derrick Isaacson</li> <li>fnx</li> <li>Josh Goldberg ✨</li> <li>Kirk Waiblinger</li> <li>Marta Cardoso</li> <li>Michaël De Boey</li> <li>Tristan Rasmussen</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/4cf8ec7201a01141162f67da27c7bf7b886b712d"><code>4cf8ec7</code></a> chore(release): publish 7.3.0</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/d2995df028831191881079fa62e1f38dc10e2c59"><code>d2995df</code></a> fix(eslint-plugin): [no-unnecessary-type-assertion] fix false negative for co...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/2869c68b28054bc1b69bbd0eecb58a12d015b988"><code>2869c68</code></a> feat(eslint-plugin): [prefer-reduce-type-parameter] supports tuple, union, in...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/d830364226513f8556fe53a0901c9c0c70e05204"><code>d830364</code></a> test(eslint-plugin): [no-unnecessary-type-assertion] add tests with noUncheck...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/04e32d6834c19160fb4f44f812a3e64671fca893"><code>04e32d6</code></a> fix(eslint-plugin): [class-literal-property-style] ignore property assigned i...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/612875bced1cd5a197a97c58dc9a89bf9e59cd8a"><code>612875b</code></a> fix(eslint-plugin): [explicit-function-return-type, explicit-module-boundary-...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/da006b1c9bb758b51c52c8b5af4ce43b44976e3f"><code>da006b1</code></a> fix(eslint-plugin): [ban-ts-comment] more accurate handling of multiline comm...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/71bfb7c6fc250413ce783d57f20a686e9e210b12"><code>71bfb7c</code></a> chore: fix ast-spec type import snapshot errors (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin/issues/8699">#8699</a>)</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/fb18de9c953ce4e90dae7e053d2e987b2dca3181"><code>fb18de9</code></a> fix(eslint-plugin): [no-unused-expressions] false negatives when using assert...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/f7323be7ac3e9d924fb03ff6b229eede078a96bf"><code>f7323be</code></a> fix(eslint-plugin): [no-unnecessary-qualifier] handle merge namespace with en...</li> <li>Additional commits viewable in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v7.3.0/packages/eslint-plugin">compare view</a></li> </ul> </details> <br /> Updates `@typescript-eslint/parser` from 7.2.0 to 7.3.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/parser</code>'s releases</a>.</em></p> <blockquote> <h2>v7.3.0</h2> <h2>7.3.0 (2024-03-18)</h2> <h3>🚀 Features</h3> <ul> <li><strong>eslint-plugin:</strong> [restrict-template-expressions] add <code>allowArray</code> option (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8389">#8389</a>)</li> <li><strong>eslint-plugin:</strong> add meta.docs.recommended setting for strict config options (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8364">#8364</a>)</li> <li><strong>eslint-plugin:</strong> add rule <code>use-unknown-in-catch-callback-variables</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8383">#8383</a>)</li> <li><strong>eslint-plugin:</strong> [prefer-reduce-type-parameter] supports tuple, union, intersection (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8642">#8642</a>)</li> <li><strong>eslint-plugin-internal:</strong> add internal lint rule no-relative-paths-to-internal-packages (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8596">#8596</a>)</li> <li><strong>typescript-estree:</strong> disallow switch statements with multiple default cases (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8411">#8411</a>)</li> <li><strong>utils:</strong> add parser name to thrown parser error message (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8484">#8484</a>)</li> </ul> <h3>🩹 Fixes</h3> <ul> <li>correct <code>engines.node</code> constraints in <code>package.json</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8671">#8671</a>)</li> <li><strong>eslint-plugin:</strong> [unbound-method] check method definition in object literal using longhand form (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8637">#8637</a>)</li> <li><strong>eslint-plugin:</strong> [consistent-type-imports] handle imports without specifiers (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8308">#8308</a>)</li> <li><strong>eslint-plugin:</strong> [no-redundant-type-constituents] incorrectly marks & string as redundant (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8282">#8282</a>)</li> <li><strong>eslint-plugin:</strong> [no-unnecessary-qualifier] handle merge namespace with enum (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8591">#8591</a>)</li> <li><strong>eslint-plugin:</strong> [no-unused-expressions] false negatives when using assertions (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8668">#8668</a>)</li> <li><strong>eslint-plugin:</strong> [ban-ts-comment] more accurate handling of multiline comments (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8416">#8416</a>)</li> <li><strong>eslint-plugin:</strong> [explicit-function-return-type, explicit-module-boundary-types] improved checking for allowHigherOrderFunctions option (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8508">#8508</a>)</li> <li><strong>eslint-plugin:</strong> [class-literal-property-style] ignore property assigned in constructor (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8412">#8412</a>)</li> <li><strong>eslint-plugin:</strong> [no-unnecessary-type-assertion] fix false negative for const variable declarations (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8558">#8558</a>)</li> <li><strong>typescript-estree:</strong> fix the issue of single run inferring in the pnpm repo (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/3811">#3811</a>, <a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/8702">#8702</a>)</li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Abraham Guo</li> <li>Alexu</li> <li>Arka Pratim Chaudhuri <a href="https://github.com/arka1002"><code>@arka1002</code></a></li> <li>auvred <a href="https://github.com/auvred"><code>@auvred</code></a></li> <li>Derrick Isaacson</li> <li>fnx <a href="https://github.com/DMartens"><code>@DMartens</code></a></li> <li>Josh Goldberg ✨</li> <li>Kirk Waiblinger <a href="https://github.com/kirkwaiblinger"><code>@kirkwaiblinger</code></a></li> <li>Marta Cardoso <a href="https://github.com/up201304504"><code>@up201304504</code></a></li> <li>Michaël De Boey</li> <li>Tristan Rasmussen</li> <li>YeonJuan <a href="https://github.com/yeonjuan"><code>@yeonjuan</code></a></li> </ul> <p>You can read about our <a href="https://main--typescript-eslint.netlify.app/users/versioning">versioning strategy</a> and <a href="https://main--typescript-eslint.netlify.app/users/releases">releases</a> on our website.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md"><code>@typescript-eslint/parser</code>'s changelog</a>.</em></p> <blockquote> <h2>7.3.0 (2024-03-18)</h2> <h3>🩹 Fixes</h3> <ul> <li>correct <code>engines.node</code> constraints in <code>package.json</code></li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Abraham Guo</li> <li>Alexu</li> <li>Arka Pratim Chaudhuri</li> <li>auvred</li> <li>Derrick Isaacson</li> <li>fnx</li> <li>Josh Goldberg ✨</li> <li>Kirk Waiblinger</li> <li>Marta Cardoso</li> <li>Michaël De Boey</li> <li>Tristan Rasmussen</li> <li>YeonJuan</li> </ul> <p>You can read about our <a href="https://main--typescript-eslint.netlify.app/users/versioning">versioning strategy</a> and <a href="https://main--typescript-eslint.netlify.app/users/releases">releases</a> on our website.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/4cf8ec7201a01141162f67da27c7bf7b886b712d"><code>4cf8ec7</code></a> chore(release): publish 7.3.0</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/883f22089df0846eab6d0c1443e5ea4cfcb9ed52"><code>883f220</code></a> fix: correct <code>engines.node</code> constraints in <code>package.json</code> (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser/issues/8671">#8671</a>)</li> <li>See full diff in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v7.3.0/packages/parser">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anna Bocharova <[email protected]> Co-authored-by: Anna Bocharova <[email protected]>
[Jest 30](https://github.com/jestjs/jest/milestone/15) is coming soon requiring higher Node.js version. ~~Since it's an optional peer dependency I made an arrangement to avoid breaking changes in `express-zod-api` itself.~~ Addressed to v18 having min Node version 18.18.
RobinTail
added
dependencies
Pull requests that update a dependency file
breaking
Backward incompatible changes
labels
Mar 18, 2024
RobinTail
commented
Mar 18, 2024
RobinTail
commented
Mar 19, 2024
RobinTail
added
refactoring
The better way to achieve the same result
and removed
breaking
Backward incompatible changes
labels
Mar 19, 2024
rc released |
Merged
Current compatibility state
|
RobinTail
added a commit
that referenced
this pull request
May 13, 2024
![image](https://github.com/RobinTail/express-zod-api/assets/13189514/f090c11f-4d73-409a-8546-5c586adb0afc) Pebbles LaDime (Dime) Doe was a black transgender woman. https://edition.cnn.com/2024/02/25/us/dime-doe-trial-south-carolina-federal-hate-crime/index.html https://www.nbcnews.com/feature/nbc-out/south-carolina-death-marks-14th-black-transgender-woman-killed-u-n1040971 https://www.justice.gov/opa/pr/south-carolina-man-found-guilty-hate-crime-killing-transgender-woman-because-her-gender Transgender women suffer too frequently from transphobic violence and cruelty, being the less protected social group. I'd like to raise an awareness of this problem. Humans should be creators — not killers. But most importantly, I want every transgender girl to have an opportunity to create applications quickly and, in general, learn to write code easily in order to receive job offers and leave dangerously transphobic territories for more favorable and civilized ones, and live happily there. Protect transgender women. ------------------------------ This version is focused on making `express-zod-api` a complete `zod` plugin. In this regard `withMeta` is removed in favor of the recommended approach on extending `zod` functionality, which opens up opportunities for new features and simplifies the consumer experience. Another improvement has been made for parsers: they are now applied selectively depending on the type of expected request. - #1693 - #1705 - #1707 - Theoretically #1631 - In advance #1708 - #1726 - #1736 - #1741 - #1745 - #1762 - #1756 - #1766 - #1730 - #1747 - #1748 - #1755 - #1760 - Not included, but comes later: #1750⚠️ don't squash it, to avoid conflicts with #1750
Closing this in favour of #1767 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
refactoring
The better way to achieve the same result
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires min Node 18.18.0 or 20.9.0 — addressed in base #1692
So far it has a lot of compatibility warnings, but it works.
Rollout related issue:
eslint/eslint#18093
StackOverflow topic:
https://stackoverflow.com/questions/74237042/how-to-correctly-configure-the-parser-plugins-with-eslints-new-flat-config
Tracking issues: