Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation removal contact_solver #21225

Closed
jwnimmer-tri opened this issue Apr 1, 2024 · 3 comments · Fixed by #21294
Closed

Deprecation removal contact_solver #21225

jwnimmer-tri opened this issue Apr 1, 2024 · 3 comments · Fixed by #21294
Assignees
Labels

Comments

@jwnimmer-tri
Copy link
Collaborator

The MbP has some deprecations related to the contact solver:

DRAKE_DEPRECATED(
"2024-04-01",
"Use set_discrete_contact_approximation() to set the contact model "
"approximation. The underlying solver will be inferred automatically.")

/// Use discrete_contact_approximation to set the contact model approximation.
/// The underlying solver will be inferred automatically. The deprecated code
/// will be removed from Drake on or after 2024-04-01.
std::string discrete_contact_solver{""};
// TODO(amcastro-tri): Along the removal of discrete_contact_solver on or
// after 2024-04-01, update the default value of
// discrete_contact_approximation to be non-empty. The value will be either
// "similar" or "lagged", to be decided based on the information we collect
// from our users.

Normally I'd just remove the deprecated code myself, but I can't this time because I don't have the "information we collect from users".

Please remove the deprecated code / comments and adjust the nearby code as-necessary.

@jwnimmer-tri
Copy link
Collaborator Author

I think probably this ticket is holding up #21095, so I hope to have us resolve this sooner than later.

@amcastro-tri As of today, which of "similar" or "lagged" (or "sap?) is our best guess at the most useful default value? I can open the PR if you like, I just don't know which one to choose.

@amcastro-tri
Copy link
Contributor

Per f2f: running kLagged would be ideal in that it does not introduce artifacts results of the convexification (i.e. "gliding" when sliding). However, kLagged introduced a "weak" coupling of friction and normal forces that might impact the perfomance (meaning predicted success/failure) of grasping tasks in simulation. In this regard, kSimilar is the safe bet, in that it solves most of the big issues we had with kSap and introduces Hunt & Crossley for the accurate and stable modeling of dissipation.

See #21294, thus far a WIP until we confirm all tests pass. I run a few tests locally and they succeded. Lets wait for Drake CI and Anzu CI for the final veredict.

@jwnimmer-tri
Copy link
Collaborator Author

@amcastro-tri Would you like to add this to our project board, for yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants