Vtol rework modified #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having vtol_status published in commander make sense since the flags it sets can be used in other vtol modules without checking for switch positions in all modules individually. Also, in future, it might be necessary to allow/deny vtol transition with the switch when flying in hands free auto mode. Commander would be a good place to allow/deny such transitions(Imagine the vehicle doing a auto_mission and the pilot switches the transition switch).
I tried to include the 'vtol_fw_permanent_stab' thing with the parameter as you do in the vtol_att_control app, but i have not tested that, since we don't use it. The transition switch is tested and now works fine for us.