best effort close client #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. Pre-existing lint errors can be ignored. I'll refactor GitHub actions so that the tests can still run even when linter fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove assert that connection closing is successful.
If the jack server is shutdown/restarted while the client connection is up then the closing will fail and you get a thread panic from the assert.
Furthermore the whole client is forever "bricked" since the assert will happen while holding the CREATE_OR_DESTROY_CLIENT_MUTEX.lock(). The mutex will get a PoisonError which prevents a new client connection to be created again. The mutex is a lazy_static "singleton" so it prevents ANY client to be created for the duration of the application.