-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBT Java 8 Docker Image #1023
Merged
Merged
MBT Java 8 Docker Image #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: cmd/testdata/mtahtml5/mta.sh modified: integration/testdata/mtahtml5/mta.sh modified: scripts/build_image modified: scripts/common_image
young-yang03
changed the title
Cloud mta build tool docker image
MBT Java 8 Docker Image
Dec 29, 2022
jerome-benoit
previously requested changes
Dec 29, 2022
9 tasks
young-yang03
commented
Feb 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finish adding java8 docker image support and all code problem fix
@rodibrin PR 1023 is only for java 8 support and npm global install problem will be fixed in PR 1026
modified: test/goss/goss_template.yaml
young-yang03
dismissed
jerome-benoit’s stale review
February 7, 2023 09:50
To support customer use the latest docker image, Xin Ye will hand over the review.
XinYe22
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Java 8 Docker Image build and publish.
Fix npm packages global installation #1026
Add a link to the design (if applicable).
Checklist