Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup PATH variable mangling #1026

Closed
wants to merge 9 commits into from
+1 −2
Closed

Cleanup PATH variable mangling #1026

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
24a0f5e
Fix npm link usage at build
jerome-benoit Jan 18, 2023
7f5f1fd
Improve npm usage without sudo
Jan 22, 2023
9fa7ca9
Update Dockerfile_mbtci_template
jerome-benoit Jan 23, 2023
68a9b75
Fix variables name usage
Jan 23, 2023
8b3a2a0
Update Dockerfile_mbtci_template
jerome-benoit Jan 31, 2023
31f6cb1
Update Dockerfile_mbtci_template
jerome-benoit Feb 2, 2023
8edaa91
Merge branch 'master' into jerome-benoit-patch-1
jerome-benoit Feb 7, 2023
14f578f
Fix mismerge
Feb 7, 2023
bcf6c26
Merge branch 'master' into jerome-benoit-patch-1
jerome-benoit Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Dockerfile_mbtci_template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,12 @@ RUN set -ex \
&& python2.7 --version \
&& python3 --version

# Allow global npm packages install without sudo
RUN set -ex \
&& mkdir ${MTA_USER_HOME}/.npm-global \
jerome-benoit marked this conversation as resolved.
Show resolved Hide resolved
&& chown -R ${MTA_USER}:${MTA_USER} ${MTA_USER_HOME}
ENV NPM_CONFIG_PREFIX ${MTA_USER_HOME}/.npm-global
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the spec it's
ENV <key>=<value>
does it work without the equal too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are working. The current Dockerfile use space, so let's keep it consistent with the style already used.


ENV PATH=$PATH:./node_modules/.bin HOME=${MTA_USER_HOME}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the image i used i do not have this path entry:

mta@63fceb6d640d:~$ echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

is it intended that the root user has the home of mta?

root@b40df04c7063:/project# id
uid=0(root) gid=0(root) groups=0(root)
root@b40df04c7063:/project# echo $HOME
/home/mta

Copy link
Collaborator Author

@jerome-benoit jerome-benoit Jan 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not intended and a genuine security bug, and as well as the HOME env variable redefinition.
The PATH env variable mangling is buggy as hell in that Dockerfile. I plan to fix it but in another PR.

Thanks.

jerome-benoit marked this conversation as resolved.
Show resolved Hide resolved
WORKDIR /project
USER ${MTA_USER}
USER ${MTA_USER}