Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] 채우기 모임 전체 조회 API 클래스 분리 진행 #146

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

khyojun
Copy link
Member

@khyojun khyojun commented Jan 19, 2025

PULL REQUEST

#️⃣관련 이슈

🎋 작업중인 브랜치

💡 작업내용

  • 채우기 전체 모임 조회 api 로직을 클래스 분리를 통해 facade의 코드에서 역할을 분리시키는 작업을 진행시켰습니다.

🔑 주요 변경사항

  • 클래스 분리 작업 진행
   public List<ActiveGroupsResponse> getFillGroups(long userId, Category category) {
        UserEntity currentUser = userService.getUserById(userId);
        GroupResponsesDto groupResponsesDto = prepareGroupResponsesFacade.prepareGroupResponses(
            currentUser, category);


        List<GroupVo> groupVos = activeGroupResponseAggregator.aggregateActiveGroupResponses(
            groupResponsesDto, currentUser);

        return groupVos.stream()
            .filter(groupVo -> lectureTimeSlotService.isActiveGroupsInLectureTimeSlot(currentUser,
                groupVo))
            .map(ActiveGroupsResponse::fromGroupVo)
            .collect(Collectors.toList());
    }

🏞 스크린샷

스크린샷을 첨부해주세요.

image

closes #142

@khyojun khyojun added the 🏭 refactor refactoring code label Jan 19, 2025
@khyojun khyojun requested a review from 2hyunjinn January 19, 2025 22:06
@khyojun khyojun self-assigned this Jan 19, 2025
Copy link

github-actions bot commented Jan 19, 2025

Test Results

13 files  13 suites   3s ⏱️
59 tests 59 ✅ 0 💤 0 ❌
63 runs  63 ✅ 0 💤 0 ❌

Results for commit 389b2b2.

♻️ This comment has been updated with latest results.

@khyojun khyojun changed the title Refactor/#142 [refactor] 채우기 모임 전체 조회 API 클래스 분리 진행 Jan 20, 2025
Copy link
Collaborator

@2hyunjinn 2hyunjinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 되네용!!! 큰 거 하나 처리하셨네요..!!!

@2hyunjinn 2hyunjinn merged commit 53a5c8b into main Jan 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏭 refactor refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] 채우기 모임 전체 조회 API 클래스 분리 진행
2 participants