「現段階の応募人数」をクラス別に表示 #224
Open
「現段階の応募人数」をクラス別に表示 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
これなんで落ちてるの？ |
|
今回の創作展ではなし |
|
Code Climate has analyzed commit 09c45f2 and detected 0 issues on this pull request. View more on Code Climate. |
Cj-bc
reviewed
Sep 18, 2018
| @@ -138,6 +138,27 @@ def test_get_specific_lottery(client): | |||
| assert resp.get_json() == lottery | |||
|
|
|||
|
|
|||
| def test_lottery_application_num(client): | |||
There was a problem hiding this comment.
このテストは実質schemaのテストだからtest/schemas.pyに入れたほうがいいと思う
|
委員会「やらないで」だそうです。 |
shino16
added
rejected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更内容
修正後の挙動:
/lotteries/{id} [GET]のデータにapplication_numを追加影響範囲
フロントエンドの対応を待ちましょう