Merge pull request 'Abandon focus stealing in FieldSlot' (#267) from …

…field-slot-abandon into main Reviewed-on: https://git.samerion.com/Samerion/Fluid/pulls/267
Samerion · Dec 26, 2024 · 9d19e62 · 9d19e62
2 parents 925917e + 2411374
commit 9d19e62
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 53 deletions.
diff --git a/tests/legacy/field_slot.d b/tests/legacy/field_slot.d
@@ -1,3 +1,4 @@
+@Migrated
 module legacy.field_slot;
 
 import fluid;
@@ -45,6 +46,7 @@ unittest {
 }
 
 @("FieldSlot can take hover from non-hoverable child nodes")
+@Abandoned
 unittest {
 
     import fluid.space;

diff --git a/tests/nodes/field_slot.d b/tests/nodes/field_slot.d
@@ -38,56 +38,3 @@ unittest {
         .runWhileDrawing(root);
 
 }
-
-@("FieldSlot can \"steal\" hover from non-hoverable child nodes")
-version (none)  // TODO
-unittest {
-
-    Label theLabel;
-    TextInput input;
-
-    // This time around use a vspace, so it won't trigger hover events when pressed outside
-    auto slot = fieldSlot!vspace(
-        layout!(1, "fill"),
-        nullTheme,
-        theLabel = label("Hello, World!"),
-        input = textInput(),
-    );
-    auto hover = hoverChain();
-    auto focus = focusChain();
-    auto root = chain(hover, focus, slot);
-    root.draw();
-
-    // Hover outside
-    hover.point(Vector2(500, 500))
-        .then((a) {
-
-            assert(hover.hoverOf(a.pointer) is null);
-            assert(!hover.isHovered(slot));
-
-            // Cannot press anything
-            a.press;
-
-            assert(!hover.isHovered(slot));
-
-            // Hover the label
-            return a.move(Vector2(5, 5));
-
-        })
-        .then((a) {
-
-            // Press
-            a.press;
-
-            return root.nextFrame;
-
-        })
-        .then({
-
-            // Focus should be transferred once actions have been processed
-            assert(focus.isFocused(input));
-
-        })
-        .runWhileDrawing(root);
-
-}