Feature/change language #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enable to switch between english and system language
- the language switch option now also works for API Levels > 25 - replaced toast message with Alert Dialog - app now restarts itself on language change
|
This is very helpful. I see no reason why it shouldn't be merged. |
SamouraiDev
force-pushed
the
develop
branch
from
be4aae7 to
c71f21a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I adapted my last PR to now also work on API > 25 (sorry for not testing that last time)
This time I tested it on Emulators with API 22, 24, 25, 26, 28 and Samsug S6 (API 24), all worked.
Additionally I replaced the toast message with an alert dialog which, when accepted will automatically restart the app.