This repository has been archived by the owner on May 7, 2021. It is now read-only.
Explicitly make all foreign key deletes cascade #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm for the most part. Can we add some tests for this functionality? |
|
Yes |
|
should also remove references of elements from conditions |
|
@Trinovantes that is much more complicated as there isn't really a way of easily determining whether an element has references to conditions right now. Captured in #428 |
joshkalpin
force-pushed
the
josh/explicit-cascade
branch
from
65d8b98 to
93b43dd
Compare
Ommy
added a commit
that referenced
this pull request
Mar 9, 2016
Explicitly make all foreign key deletes cascade
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It defaults to this, but better for my piece of mind and it becomes mandatory to do this in Django 2.0