-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
287 feature extract multiple columns from one prejoined object #297
Closed
tkiehn
wants to merge
26
commits into
main
from
287-feature-extract-multiple-columns-from-one-prejoined-object
Closed
287 feature extract multiple columns from one prejoined object #297
tkiehn
wants to merge
26
commits into
main
from
287-feature-extract-multiple-columns-from-one-prejoined-object
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion error message
…e-prejoined-object
…prejoin_column_names change extract_input_columns to handle the new prejoin list syntax. change process_prejoined_columns to parse the old dict syntax to the new list syntax, merging prejoins with the same conditions. add extract_prejoin_column_names which can handle the new list syntax
…tract_prejoin_column_names
…ing of commas for ghost records
Naming join relations using "AS" is not allowed in oracle
Merged into test (0557fbf) |
Closed in favor of #300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new syntax for prejoins, allowing extraction of multiple columns from the same prejoin-source:
In this example we join the source model with
business_raw
and extractid
andnumber
and assign an alias for each column.Assigning an alias is optional, but if done, the number of
extract_columns
has to match the amount ofaliases
.For each prejoin-target a new list, containing at least a dictionary for extract_columns and values for ref_model(or source_name & source_table) and the column names, needs to be defined.
aliases are optional, but if given, must be the same length as extract_columns.
this_column_name & ref_column_name allow multiple columns
ref_model are changeable to src_name & src_table
The old syntax is still valid and can be used if desired.
Fixes #287
Type of change
Please delete options that are not relevant.
Checklist:
ToDO: Update Docs to include the new syntax