Merge pull request #332 from SciML/bgc/hydraulic_init

Remove defaults for Hydraulic components
SciML · Sep 23, 2024 · 36f4018 · 36f4018
2 parents 2544d26 + 099d5e8
commit 36f4018
Show file tree

Hide file tree

Showing 8 changed files with 283 additions and 255 deletions.
diff --git a/docs/src/connectors/sign_convention.md b/docs/src/connectors/sign_convention.md
@@ -159,11 +159,10 @@ using ModelingToolkitStandardLibrary.Hydraulic.IsothermalCompressible
 
 @mtkmodel ConstantMassFlow begin
     @parameters begin
-        p_int
         dm
     end
     @components begin
-        port = HydraulicPort(; p_int)
+        port = HydraulicPort()
     end
     @equations begin
         port.dm ~ -dm
@@ -176,7 +175,7 @@ A positive input mass flow leads to an increasing pressure (in this case we get
 ```@example sign_convention
 @mtkmodel System begin
     @components begin
-        volume = FixedVolume(; vol = 10.0, p_int = 0.0)
+        volume = FixedVolume(; vol = 10.0)
         flow = ConstantMassFlow(; dm = 1)
         fluid = HydraulicFluid()
     end