Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix states -> unknowns #289

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Fix states -> unknowns #289

merged 1 commit into from
Apr 21, 2024

Conversation

BambOoxX
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@BambOoxX
Copy link
Contributor Author

This probably needs additional tests given that it was not caught earlier...

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.19%. Comparing base (fb8a224) to head (ccf23a2).

Files Patch % Lines
src/Blocks/analysis_points.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   61.53%   54.19%   -7.34%     
==========================================
  Files          46       46              
  Lines        1448     1644     +196     
==========================================
  Hits          891      891              
- Misses        557      753     +196     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 4aff0de into SciML:main Apr 21, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants