Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version and changelog #1482

Merged
merged 6 commits into from
Oct 24, 2023
Merged

New version and changelog #1482

merged 6 commits into from
Oct 24, 2023

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Oct 17, 2023

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Prep for new release.

2. Jira task / GitHub issue

DDS-1700

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Database change: Remember the to include a new migration version, or explain here why it's not needed.
  • Bug fix
  • Security Alert fix
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Prettier
  • Yamllint
  • Tests
  • CodeQL
  • Trivy
  • Snyk

@i-oden i-oden self-assigned this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1482 (59e44d5) into dev (de6e3fb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1482   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files          29       29           
  Lines        4484     4484           
=======================================
  Hits         4050     4050           
  Misses        434      434           
Files Coverage Δ
dds_web/version.py 100.00% <100.00%> (ø)

@i-oden i-oden requested a review from rv0lt October 24, 2023 10:40
@i-oden i-oden marked this pull request as ready for review October 24, 2023 10:40
@i-oden i-oden requested a review from valyo October 24, 2023 10:40
Copy link
Member

@rv0lt rv0lt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! Good aclarations of the changes

@i-oden i-oden merged commit 615997f into dev Oct 24, 2023
14 checks passed
@i-oden i-oden deleted the DDS-1700-new-release-for-api branch October 24, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants