-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alert unit email and us if storage threshold reached #1562
Alert unit email and us if storage threshold reached #1562
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1562 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
…orage-threshold-reached
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick note -- add a description to the PR
Also, the title says "instead", and it should be "Alert unit and us..." or something like that |
…orage-threshold-reached
migrations/versions/e02fe8fde71e_unit_contact_email_non_nullable.py
Outdated
Show resolved
Hide resolved
…orage-threshold-reached
Checked the two instances and there is no current unit that has a null contact_email |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though we currently don't have any values that are null, we still need to include the possibility in the migration. An example is seen in 666003748d14_change_active_nullable_and_default
for example, but there are others too (not regarding nullable=False though I don't think), add something similar.
…orage-threshold-reached
…orage-threshold-reached
migrations/versions/0cd0a3b251e0_unit_contact_email_non_nullable.py
Outdated
Show resolved
Hide resolved
…le.py Co-authored-by: Ina Odén Österbo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to merge once you have tested it locally (using flask db downgrade
and upgrade
etc)
Tested manually |
Read this before submitting the PR
If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.
1. Description / Summary
Modify the monitor usage command to send an email to both the unit affected and our team in case the warning level is surpassed
2. Jira task / GitHub issue
Link to the github issue or add the Jira task ID here.
3. Type of change
What type of change(s) does the PR contain?
Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.
4. Additional information
master
branch: _If checked, read the release instructions5. Actions / Scans
Check the boxes when the specified checks have passed.
For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.