Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version & changelog #1583

Closed
wants to merge 8 commits into from
Closed

new version & changelog #1583

wants to merge 8 commits into from

Conversation

rv0lt
Copy link
Member

@rv0lt rv0lt commented Dec 13, 2024

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

new version and changelog for new release

2. Jira task / GitHub issue

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Database change: Remember the to include a new migration version, or explain here why it's not needed.
  • Bug fix
  • Security Alert fix
    • Package update
      • Major version update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Prettier
  • Yamllint
  • Tests
  • CodeQL
  • Trivy
  • Snyk

@rv0lt rv0lt self-assigned this Dec 13, 2024
@rv0lt rv0lt marked this pull request as ready for review December 13, 2024 12:58
@rv0lt rv0lt requested a review from a team as a code owner December 13, 2024 12:58
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change order so that it's consistent with the rest of the changelog, and also so that the users get the most important information first:

  • New features
  • Bugs fixed
  • Logging

The other comments I've made are less important, mainly for simplification purposes

CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
SPRINTLOG.md Outdated Show resolved Hide resolved
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged your PR regarding the CVEs so update the changelog regarding that as well.

@rv0lt rv0lt requested a review from i-oden December 16, 2024 09:27
CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
@rv0lt rv0lt requested a review from i-oden December 16, 2024 12:03
CHANGELOG.rst Outdated Show resolved Hide resolved
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the date in the changelog and move the row in the sprintlog to the correct sprint

SPRINTLOG.md Show resolved Hide resolved
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're good to merge once actions have passed and @valyo has approved

@i-oden i-oden requested a review from valyo December 17, 2024 07:32
@i-oden i-oden mentioned this pull request Dec 17, 2024
23 tasks
@i-oden
Copy link
Member

i-oden commented Dec 17, 2024

actions fixed in: #1584

@i-oden i-oden closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants