Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try/catch PredefinedPropertyLabelMismatchException #25

Merged
merged 1 commit into from
Sep 16, 2018
Merged

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Sep 15, 2018

This PR is made in reference to: SemanticMediaWiki/SemanticMediaWiki#3431 (comment)

This PR addresses or contains:

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames merged commit 27ba1f7 into master Sep 16, 2018
@mwjames mwjames deleted the exception branch September 16, 2018 00:26
@kghbln
Copy link
Member

kghbln commented Sep 24, 2018

@mwjames This indeed catches the user facing issues with the mismatch, however "rebuildFulltextSearchTable.php" still fails:

[ac60fde656b2ac5f88ba566d] [no req]   SMW\Exception\PredefinedPropertyLabelMismatchException from line 94 of /../w/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Property.php: There is no predefined property with "_RL_DEF".

Backtrace:

#0 /../w/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Property.php(488): SMW\DIProperty->__construct(string, boolean)
#1 /../w/extensions/SemanticMediaWiki/src/SQLStore/QueryEngine/Fulltext/SearchTable.php(105): SMW\DIProperty::newFromUserLabel(string)
#2 /../w/extensions/SemanticMediaWiki/src/SQLStore/QueryEngine/Fulltext/SearchTableRebuilder.php(291): SMW\SQLStore\QueryEngine\Fulltext\SearchTable->isExemptedPropertyById(string)
#3 /../w/extensions/SemanticMediaWiki/src/SQLStore/QueryEngine/Fulltext/SearchTableRebuilder.php(266): SMW\SQLStore\QueryEngine\Fulltext\SearchTableRebuilder->doRebuildFromRows(SMW\SQLStore\QueryEngine\Fulltext\SearchTable, string, string, Wikimedia\Rdbms\ResultWrapper)
#4 /../w/extensions/SemanticMediaWiki/src/SQLStore/QueryEngine/Fulltext/SearchTableRebuilder.php(207): SMW\SQLStore\QueryEngine\Fulltext\SearchTableRebuilder->doRebuildByPropertyTable(SMW\SQLStore\PropertyTableDefinition)
#5 /../w/extensions/SemanticMediaWiki/src/SQLStore/QueryEngine/Fulltext/SearchTableRebuilder.php(114): SMW\SQLStore\QueryEngine\Fulltext\SearchTableRebuilder->doRebuild()
#6 /../w/extensions/SemanticMediaWiki/maintenance/rebuildFulltextSearchTable.php(107): SMW\SQLStore\QueryEngine\Fulltext\SearchTableRebuilder->rebuild()
#7 /../w/maintenance/doMaintenance.php(94): SMW\Maintenance\RebuildFulltextSearchTable->execute()
#8 /../w/extensions/SemanticMediaWiki/maintenance/rebuildFulltextSearchTable.php(177): require_once(string)
#9 {main}

Best to just delete the tables and restart?

@mwjames
Copy link
Contributor Author

mwjames commented Sep 24, 2018 via email

@kghbln
Copy link
Member

kghbln commented Sep 24, 2018

Best leaves this for now. Please create a smw ticket with the
stacktrace and I'll respond with fix.

Ok and done with SemanticMediaWiki/SemanticMediaWiki#3482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants