Update extractor to fix "ios client response not valid error" on basic branch #32
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esugaring library neo flavor
whistlingwoods
changed the title
Repository owner
locked and limited conversation to collaborators
Jan 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the PR
Note1: This basic branch has somewhat Updated AGP to 7.4.0, Gradle to 7.5.1 and other libraries required for Desugaring library update to nio_2.0.3
Note2: Desugaring library's desugar_jdk_libs_nio flavor is needed for proper desugaring the methods used in latest extractor fixes for "ios client response not valid error" for apps to be run on devices lower version than Android 8 (Oreo)/
Note3: Or use JDK8 version of extractor or UTF_8 instead of StandardCharsets.UTF_8 because StandardCharsets.UTF_8 does not get desugared by desugaring library 1.1.6
Note4: basic branch uses conscrypt provider & uses tls 1.2 & 1.3 protocols Hence it should be tested throughly on actual devices whether it works on actual devices.
Fixes the following issue(s)
Relies on the following changes
APK testing:
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
NewpipeLegacy-basic-debug-v0.23.3.zip
Due diligence