-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert icloud-auth to async, integrate anisette-v3 and support SMS auth #18
Merged
Merged
Changes from 4 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2a57103
feat(icloud-auth): convert to async and integrate anisette-v3 via omn…
TaeHagen 0989820
feat(icloud-auth): support sms auth
TaeHagen 645930b
feat(icloud-auth): support passing anisette configuration directly, a…
TaeHagen 5a36972
fix(icloud-auth): Re-login after 2fa to get account data including PET
TaeHagen fd9c035
feat(icloud-auth): support number retrieval, header access, and extra…
TaeHagen b87bda0
feat: convert to `thiserror`and fix error handling
TaeHagen 4577373
fix(icloud-auth): disable excess logging
TaeHagen 6112392
fix(omnisette): remove extra logging
TaeHagen bb39f21
fix(icloud-auth): more exports and enum formatting
TaeHagen 6ca1554
fix(icloud-auth): avoid unnessesary cloning
TaeHagen dae08a5
fix(icloud-auth): further login refactoring
TaeHagen 0a15719
fix(icloud-auth): make pet return optional
TaeHagen f75a45e
fix(icloud-auth): send + sync fixes
TaeHagen a277a4c
fix(icloud-auth): fix error situation
TaeHagen 7fe6075
fix(icloud-auth): refresh anisette data every 60 seconds
TaeHagen d0e421e
fix(omnisette): use bundled roots for android
TaeHagen e64160d
feat(icloud-auth): support getting account name
TaeHagen a1ac379
Fix SMS 2fa error handling
TaeHagen 7ca9bb7
Support list phone numbers 201
TaeHagen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would maybe add a generic NeedSecondStep(action: String) too, to handle all the other cases (along with a way to skip the second step if Apple provided all the required tokens).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a state machine, and the "Logged in" state is the finished state. Are there any other steps other than those two? I think it's better to panic now to bring attention to them if they ever show up. But I guess it could also be an error state?