Skip to content

Commit

Permalink
(For Gary) Add support for $app and $browser to $content_status, $ord…
Browse files Browse the repository at this point in the history
…er_status, and $security_notification (#39)

* Add support for $app and $browser to $content_status, $order_status, and $security_notification`

* version bump
  • Loading branch information
hd authored Feb 21, 2019
1 parent d5242d0 commit cb121c2
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGES.MD
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
2.7.0 (2019-02-18)
=================
- Add support for `$app` and `$browser` to `$content_status`, `$order_status`, and `$security_notification`

2.6.0 (2019-01-30)
=================

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ Java 1.7 or later.
<dependency>
<groupId>com.siftscience</groupId>
<artifactId>sift-java</artifactId>
<version>2.6.0</version>
<version>2.7.0</version>
</dependency>
```
### Gradle
```
dependencies {
compile 'com.siftscience:sift-java:2.6.0'
compile 'com.siftscience:sift-java:2.7.0'
}
```
### Other
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ apply plugin: 'signing'
apply plugin: 'java-library-distribution'

group = 'com.siftscience'
version = '2.6.0'
version = '2.7.0'
sourceCompatibility = 1.7
targetCompatibility = 1.7

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import com.google.gson.annotations.Expose;
import com.google.gson.annotations.SerializedName;

public class ContentStatusFieldSet extends EventsApiRequestFieldSet<ContentStatusFieldSet> {
public class ContentStatusFieldSet extends BaseAppBrowserFieldSet<ContentStatusFieldSet> {
public static ContentStatusFieldSet fromJson(String json) {
return gson.fromJson(json, ContentStatusFieldSet.class);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import com.google.gson.annotations.Expose;
import com.google.gson.annotations.SerializedName;

public class OrderStatusFieldSet extends EventsApiRequestFieldSet<OrderStatusFieldSet> {
public class OrderStatusFieldSet extends BaseAppBrowserFieldSet<OrderStatusFieldSet> {
public static OrderStatusFieldSet fromJson(String json) {
return gson.fromJson(json, OrderStatusFieldSet.class);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
import com.google.gson.annotations.Expose;
import com.google.gson.annotations.SerializedName;

public class SecurityNotificationFieldSet extends EventsApiRequestFieldSet<SecurityNotificationFieldSet> {
public class SecurityNotificationFieldSet extends
BaseAppBrowserFieldSet<SecurityNotificationFieldSet> {
public static SecurityNotificationFieldSet fromJson(String json) {
return gson.fromJson(json, SecurityNotificationFieldSet.class);
}
Expand Down
6 changes: 6 additions & 0 deletions src/test/java/com/siftscience/BaseAppBrowserFieldSetTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import com.siftscience.model.App;
import com.siftscience.model.BaseAppBrowserFieldSet;
import com.siftscience.model.Browser;
import com.siftscience.model.ContentStatusFieldSet;
import com.siftscience.model.CreateAccountFieldSet;
import com.siftscience.model.CreateCommentFieldSet;
import com.siftscience.model.CreateListingFieldSet;
Expand All @@ -18,7 +19,9 @@
import com.siftscience.model.CustomEventFieldSet;
import com.siftscience.model.LoginFieldSet;
import com.siftscience.model.LogoutFieldSet;
import com.siftscience.model.OrderStatusFieldSet;
import com.siftscience.model.RemoveItemFromCartFieldSet;
import com.siftscience.model.SecurityNotificationFieldSet;
import com.siftscience.model.TransactionFieldSet;
import com.siftscience.model.UpdateAccountFieldSet;
import com.siftscience.model.UpdateCommentFieldSet;
Expand Down Expand Up @@ -60,6 +63,7 @@ public void testAllSubclasses() {
Class<?> [] subclasses = {
AddItemToCartFieldSet.class,
AddPromotionFieldSet.class,
ContentStatusFieldSet.class,
CreateAccountFieldSet.class,
CreateCommentFieldSet.class,
CreateListingFieldSet.class,
Expand All @@ -71,7 +75,9 @@ public void testAllSubclasses() {
CustomEventFieldSet.class,
LoginFieldSet.class,
LogoutFieldSet.class,
OrderStatusFieldSet.class,
RemoveItemFromCartFieldSet.class,
SecurityNotificationFieldSet.class,
TransactionFieldSet.class,
UpdateAccountFieldSet.class,
UpdateCommentFieldSet.class,
Expand Down

0 comments on commit cb121c2

Please sign in to comment.