Migrate jenkins CI to GH CI #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlin-sift
reviewed
Jun 24, 2024
.github/workflows/ci.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@55283cc23133118229fd3f97f9336ee23a179fcf # v1.146.0 |
There was a problem hiding this comment.
The latest release is https://github.com/ruby/setup-ruby/tree/v1.180.1. Why can not we use that?
jlin-sift
reviewed
Jun 24, 2024
jlin-sift
reviewed
Jun 24, 2024
.github/workflows/ci.yml
Outdated
| bundler-cache: true # runs 'bundle install' and caches installed gems automatically | ||
| - name: Run tests | ||
| run: | | ||
| bundle check |
There was a problem hiding this comment.
Change it to bundle check || bundle install according to circleci config.
There was a problem hiding this comment.
Remove bundle check and bundle install.
There was a problem hiding this comment.
Thanks @jlin-sift Removed check/install from test step.
jlin-sift
approved these changes
Jun 24, 2024
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Migrate jenkins CI to GH CI
Summary
Migrate jenkins CI to GH CI
Testing
Migrate jenkins CI to GH CI
Checklist