-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework page preview to use transformers. page frame now uses placeholders #24
Conversation
Ik zie dat de placeholders formaat '{placeholder}' hebben. Moustache gebruikt '{{placeholder}}', en javascript templated strings gebruiken '${placeholder}'. Ik zou liever een van die 2 zien, in de rest van de code vallen ze meer op. |
I've opted to use {{ }}. The syntax for javascript templated strings might raise the expectation of the placeholders being able to do more than just be a simple placeholder to be replaced. |
Is there a reason to match (\s+){{...}} instead of just {{...}} ? It feels a bit arbitrary. |
Yes - it will take the space-symbols from the start of the line to do indenting with, so the generated code will be indented properly as well. |
No description provided.