Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataset): push dataset with name #1510

Merged
merged 2 commits into from
Jan 10, 2025
Merged

fix(dataset): push dataset with name #1510

merged 2 commits into from
Jan 10, 2025

Conversation

ArslanSaleem
Copy link
Collaborator

@ArslanSaleem ArslanSaleem commented Jan 10, 2025

Important

Enhance push() in base.py to include dataset name in parameters and ensure dataset is saved before pushing.

  • Behavior:
    • In push() method, raise ValueError if self.path is None, ensuring dataset is saved before pushing.
    • Add name to params in push() method, using self.name or empty string if None.

This description was created by Ellipsis for d8e764d. It will automatically update as commits are pushed.

@ArslanSaleem ArslanSaleem requested a review from gventuri January 10, 2025 21:00
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 10, 2025
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to d8e764d in 34 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pandasai/dataframe/base.py:239
  • Draft comment:
    Consider suggesting the user to use the save method in the error message for clarity.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds a check to ensure that the dataset has been saved before it can be pushed. This is a good addition for error handling. However, the error message could be more informative by suggesting the user to use the save method.

Workflow ID: wflow_d4Mzgpfua01Rrpeb


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

pandasai/dataframe/base.py Outdated Show resolved Hide resolved
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@gventuri gventuri merged commit de3ddd8 into release/v3 Jan 10, 2025
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants