Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #180 #290

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix #180 #290

merged 1 commit into from
Nov 13, 2023

Conversation

sc-ivanlieckens
Copy link
Collaborator

Description / Motivation

  • Adjusted up.ps1 to validate presence of expected env variables to give a proper exception instead of weird nullreference
  • Introduced Markdig package for rendering markdown
  • Contributions in the Application can now be edited
  • Deletion of a Contribution now requests confirmation

This fixes the Issue #180

How Has This Been Tested?

Tested in local environment

Manual UI testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@IvanLieckens
Fix #180
b4aae38 
+ Adjusted up.ps1 to validate presence of expected env variables to give a proper exception instead of weird nullreference
+ Introduced Markdig package for rendering markdown
+ Contributions in the Application can now be edited
+ Deletion of a Contribution now requests confirmation
@sc-ivanlieckens sc-ivanlieckens added the enhancement New feature or request label Nov 10, 2023
@robearlam robearlam merged commit 2fe91d0 into main Nov 13, 2023
6 checks passed
@robearlam robearlam deleted the feature/180-contribution-edit branch November 13, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robearlam robearlam robearlam approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sc-ivanlieckens @robearlam @IvanLieckens