Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create people grid component and person datasource #352

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

ericsanner
Copy link
Contributor

https://trello.com/c/m9B3AaET/31-create-featured-speaker-component

image

image

Description / Motivation

  1. Added a Person Datasource template
  2. Added a People Grid datasource template and rendering

This component is flexible and can suit multiple needs on the site. People can later be linked to sessions (which can be linked to events). The people grid component has rendering parameters that allow for

  1. Number of columns
  2. Background color (paintbucket styles)
  3. Optional link to person's bio
  4. Optional links to social urls

How Has This Been Tested?

  1. Mobile, tablet and desktop
  2. With and without the background style
  3. With and without each of the content fields
  4. With and without the link to social sites
  5. Different numbers of columns

The link to biography was not tested, as that will come in a future story.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be used with dedicated Social Network. Please Name LinkedIn or Twitter or so. We might associate this with Icons. And they should be always displayed in order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have renamed the social links to linkedin and twitter. Should the twitter link be called "X"?

Copy link
Collaborator

@lovesitecore lovesitecore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Items are not consitantly using the same module. You started using the Basic Components Module. I do see a point putting it there when this becomes something more generic. But the display of other person related data is different and also business wise different. So I personally would separate these out. Just have a Speaker Template and a Featured Speaker Component. You could inherit fields to the Speaker Template from a Person Base Template. But this could be a bit overengineered. We can discuss this in todays call.

@lovesitecore lovesitecore merged commit 6039df8 into Sitecore:main Feb 16, 2024
7 checks passed
@ericsanner ericsanner deleted the feature/31-featured-speaker branch March 19, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants