Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Agenda component and related items #381

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

anbrue
Copy link
Contributor

@anbrue anbrue commented Feb 28, 2024

Description / Motivation

The Agenda component is added with PR, it is functional, not ready. It needs styling.
Also there is a FE-specific comment for the FE Devs in the team, it's about the hook.
I used the useSWR hook for fetching the data, because it is highly recommend to use that rather than the useEffect hook.
The old approach works with getStaticProps, but the problem with that is, that the data are fetched on build and especially for the agenda we need to have a recent version in place, because the agenda needs to be update in Sessionize during the event.

Let's discuss please the pros and cons of this, this is just my suggestion.

How Has This Been Tested?

Tested it locally, works in my FE app and in Pages connected to my local CM.

Types of changes

Added the component and related items.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@lovesitecore lovesitecore merged commit 695bbb8 into Sitecore:main Feb 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants