Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed orphaned serialisation items #399

Closed
wants to merge 1 commit into from
Closed

Fixed orphaned serialisation items #399

wants to merge 1 commit into from

Conversation

robearlam
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@robearlam robearlam self-assigned this Mar 13, 2024
@robearlam robearlam requested a review from lovesitecore March 13, 2024 02:43
@robearlam robearlam added bug Something isn't working SUGCON Sites labels Mar 13, 2024
lovesitecore
lovesitecore reviewed Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@lovesitecore lovesitecore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Rob, I'd rather like to keep the items and changed the parent item id of the items. This is done in PR 403. #403 Let me know what you think.

@robearlam
Copy link
Member Author

This is no longer needed, outdated by #403

@robearlam robearlam closed this Mar 14, 2024
@robearlam robearlam deleted the serialisation-fix branch June 19, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesitecore lovesitecore lovesitecore left review comments

Assignees

@robearlam robearlam

Labels
bug Something isn't working SUGCON Sites
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robearlam @lovesitecore