Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Mobile and Desktop layout for multiple components #430

Merged

Conversation

matthewgisonno
Copy link
Contributor

@matthewgisonno matthewgisonno commented Mar 26, 2024

Description / Motivation

  • Deleted 2 .scss files no longer used, styles moved to component level:
    • _component-action-banner.scss
    • _component-navigation.scss
  • Updated _list-horizontal.scss file to remove left margins from the list.
  • Updated src/Project/Sugcon2024/Sugcon/src/assets/sass/components/index.scss with removed imports.
  • Refactored ActionBanner component for using LayoutFlex component to keep consistent width/margin/padding across breakpoints.
  • Refactored Event component to keep consistent width/margin/padding across breakpoints.
  • Refactored EventTeaser component for using LayoutFlex component to keep consistent width/margin/padding across breakpoints.
  • Refactored Hero component and all variants for using LayoutFlex component to keep consistent width/margin/padding across breakpoints.
  • Updated Person image width to match design comps.
  • Refactored TextImage component for using LayoutFlex component to keep consistent width/margin/padding across breakpoints.
  • Refactored Venue component for using LayoutFlex component to keep consistent width/margin/padding across breakpoints.
  • Refactored VideoText component for using LayoutFlex component to keep consistent width/margin/padding across breakpoints.
  • Updated Accordion component for using LayoutFlex component to keep consistent width/margin/padding across breakpoints.
  • Updated IconLinkList component to better match comps.
  • Refactored PeopleGrid component for using LayoutFlex component to keep consistent width/margin/padding across breakpoints.
  • Updated a couple Storybook stories to have more realistic data and use better layouts.
  • Also updated the favicon.ico to match the Sugcon logo.

How Has This Been Tested?

Tested locally in connected mode and Storybook.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

Sorry, something went wrong.

…g design system for laying out components that match accross breakpoints.
@markvanaalst markvanaalst merged commit 593bb6b into Sitecore:main Mar 26, 2024
7 checks passed
@matthewgisonno matthewgisonno deleted the bugfix/component-mobile-fixes branch March 27, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants