Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-nextjs]: Expose MiddlewareBase class and MiddlewareBaseConfig type #1941

Merged
merged 2 commits into from
Oct 8, 2024
Merged

[sitecore-jss-nextjs]: Expose MiddlewareBase class and MiddlewareBaseConfig type #1941

merged 2 commits into from
Oct 8, 2024

Conversation

sc-keithbauer
Copy link
Contributor

@sc-keithbauer sc-keithbauer commented Oct 4, 2024 •
edited
Loading

…Config for project reusability

Description / Motivation

Expose MiddlewareBase class so it can be used by developers as a starting point for new middleware plugins in projects.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

FrankvanZ
FrankvanZ approved these changes Oct 5, 2024
View reviewed changes
Copy link

@FrankvanZ FrankvanZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just what many developers need

@yavorsk yavorsk added the backlog Issue/PR/discussion is reviewed and added to backlog for the further work label Oct 7, 2024
yavorsk
yavorsk approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@yavorsk
Copy link
Contributor

yavorsk commented Oct 8, 2024

@sc-keithbauer thanks for the contribution!
@FrankvanZ this should be available in the next minor release which comes soon.

@yavorsk yavorsk merged commit f219ae3 into Sitecore:dev Oct 8, 2024
1 check passed
art-alexeyenko pushed a commit that referenced this pull request Oct 11, 2024
@sc-keithbauer @art-alexeyenko
[sitecore-jss-nextjs]: Expose MiddlewareBase class and MiddlewareBase…
fed0b75 
…Config type (#1941)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankvanZ FrankvanZ FrankvanZ approved these changes

@yavorsk yavorsk yavorsk approved these changes

Assignees
No one assigned
Labels
backlog Issue/PR/discussion is reviewed and added to backlog for the further work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sc-keithbauer @yavorsk @FrankvanZ