Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs]: Improve performance for redirects #SXA-7834 #SXA-7866 #SXA-7780 #2003

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Dec 17, 2024

Description / Motivation

A condition for prefetch requests has been added to improve the performance of redirects.

Additionally, a condition has been added to handle Netlify requests to reduce server load.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as a good improvement! I added some comments
Of course you need to add unit tests, they are missing :)
We can jump on the call to discuss some uncertainties

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugifx/SXA-7834-improvement-perfomence-redirects branch from f67d456 to 9879878 Compare December 20, 2024 11:38
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi changed the title [sitecore-jss-nextjs]: The cache of results of pattern has been added #SXA-7834 [sitecore-jss-nextjs]: Improve performance for redirects #SXA-7834 Dec 20, 2024
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I see that you removed caching mechanism, do we still need it for standard requests? Or it's enough to skip prefetch requests to get a stable performance?
  2. Unit tests are missing (e.g. new prefetch req case)

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugifx/SXA-7834-improvement-perfomence-redirects branch 2 times, most recently from 80be9ba to 4aed299 Compare January 14, 2025 23:07
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi deleted the bugifx/SXA-7834-improvement-perfomence-redirects branch January 14, 2025 23:15
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi restored the bugifx/SXA-7834-improvement-perfomence-redirects branch January 14, 2025 23:17
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugifx/SXA-7834-improvement-perfomence-redirects branch from 4aed299 to e52d837 Compare January 14, 2025 23:18
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugifx/SXA-7834-improvement-perfomence-redirects branch from e52d837 to 3fc1966 Compare January 14, 2025 23:28
…s. Added a simpler solution for non-regex patterns to fix Netlify-related problems. Improved redirect performance.
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugifx/SXA-7834-improvement-perfomence-redirects branch from 3fc1966 to a6fdb73 Compare January 15, 2025 11:27
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@illiakovalenko illiakovalenko merged commit add7853 into dev Jan 15, 2025
1 check passed
@illiakovalenko illiakovalenko deleted the bugifx/SXA-7834-improvement-perfomence-redirects branch January 15, 2025 12:37
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi changed the title [sitecore-jss-nextjs]: Improve performance for redirects #SXA-7834 [sitecore-jss-nextjs]: Improve performance for redirects #SXA-7834 #SXA-7866 #SXA-7780 Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants