Remove Axios #2006

addy-pathania · 2025-01-08T00:30:45Z

This PR follows the Contribution Guide
Changelog updated
Upgrade guide entry added

Description / Motivation

This change is motivated by the security vulnerabilities found with the Axios library. This PR removes the default use of Axios for data fetching across the monorepo and transitions to the native fetch API.

Testing Details

Unit Test Added
Manual Test/Other (Please elaborate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

art-alexeyenko

Good work. Also a good catch that Native fetcher needs some extra unit tests.
Still, some things I'd like you to take a look at and adjust. Please check the comments.

packages/create-sitecore-jss/src/templates/nextjs-styleguide-tracking/src/lib/data-fetcher.ts

packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.ts

art-alexeyenko · 2025-01-09T21:01:45Z

packages/sitecore-jss/package.json

@@ -47,15 +47,14 @@
    "eslint": "^8.56.0",
    "eslint-plugin-jsdoc": "48.7.0",
    "mocha": "^10.2.0",
-    "nock": "^13.0.5",
+    "nock": "14.0.0-beta.7",


Just to comment on why this specific version is used, for history.
Using beta version to fix this issue: nock/nock#2397 and allow testing for component library service
Using specific beta.7 version to not encounter this error: nock/nock#2789

packages/sitecore-jss/src/data-fetcher.ts

packages/sitecore-jss/src/layout/rest-layout-service.ts

packages/sitecore-jss/src/native-fetcher.test.ts

packages/sitecore-jss/src/native-fetcher.ts

packages/sitecore-jss/src/tracking/trackingApi.ts

illiakovalenko

Overall looks good! See some questions/comments below
Applications are failing to build/start:

Angular sxp
Next.js styleguide application types check is failing
Next.js xmcloud application types check is failing

illiakovalenko · 2025-01-10T14:39:53Z

CHANGELOG.md

@@ -22,6 +22,8 @@ Our versioning strategy is as follows:
 ### 🐛 Bug Fixes

 * `[sitecore-jss-nextjs]` Fixed handling of ? inside square brackets [] in regex patterns to prevent incorrect escaping ([#1999](https://github.com/Sitecore/jss/pull/1999))
+* `[sitecore-jss]``[create-sitecore-jss]``[sitecore-jss-nextjs]``[sitecore-jss-react]``[sitecore-jss-dev-tools]``[sitecore-jss-vue]` Remove Axios ([#2006](https://github.com/Sitecore/jss/pull/2006))


Chengelog entry should mention all the removed and replaced API references. However, more details should be mentioned in upgrade guide
Also, it's a breaking change, not a bugfix

@addy-pathania Changelog is unchanged

aah i forgot push my last commit.

packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.ts

packages/sitecore-jss/src/layout/rest-layout-service.ts

packages/create-sitecore-jss/src/templates/nextjs-styleguide-tracking/src/lib/data-fetcher.ts

packages/sitecore-jss/src/native-fetcher.ts

packages/sitecore-jss-nextjs/src/index.ts

illiakovalenko · 2025-01-14T10:13:17Z

packages/sitecore-jss/src/layout/rest-layout-service.test.ts

-        expect(layoutServiceData.headers['X-Forwarded-For']).to.equal('192.168.1.10');
-        expect(layoutServiceData.data).to.deep.equal({
+      .then((layoutServiceData: LayoutServiceData & NativeDataFetcherConfig) => {
+        if (layoutServiceData.headers instanceof Headers) {


layoutServiceData can't contain headers, so you are not verifying headers anymore
check rest of unit tests

@addy-pathania we are still missing headers configuration and verification in unit tests

illiakovalenko · 2025-01-14T10:13:28Z

packages/sitecore-jss/src/layout/rest-layout-service.test.ts

-      .reply(200, (_, requestBody) => ({
-        requestBody: requestBody,
-        data: { sitecore: { context: {}, route: { name: 'xxx' } } },
-        headers: {


You are not testing response headers anymore, check rest of unit tests as well

@addy-pathania we are still missing headers configuration and verification in unit tests

packages/sitecore-jss/src/layout/rest-layout-service.ts

packages/create-sitecore-jss/src/templates/nextjs-sxa/src/pages/api/sitemap.ts

packages/sitecore-jss-dev-tools/src/package-deploy.ts

packages/sitecore-jss/src/layout/rest-layout-service.ts

CHANGELOG.md

illiakovalenko · 2025-01-15T08:51:55Z

packages/sitecore-jss/src/layout/rest-layout-service.test.ts

-      .reply(200, (_, requestBody) => ({
-        requestBody: requestBody,
-        data: { sitecore: { context: {}, route: { name: 'xxx' } } },
-        headers: {


@addy-pathania we are still missing headers configuration and verification in unit tests

illiakovalenko

Looks good, it's close to be finished!
See one re-opened comment above, related to "headers" test, still missing

packages/sitecore-jss-dev-tools/src/package-deploy.ts

CHANGELOG.md

apathania22 added 3 commits January 7, 2025 19:24

remove axios

e910eea

update changelog

b24faf6

clean up

cdb5ab6

addy-pathania requested a review from a team January 8, 2025 14:12

apathania22 added 5 commits January 8, 2025 13:20

fix tracking tests

62e2f7d

improve native fetch

346b5d5

fix error message

b8d92e0

refactor sitemap

59ab977

fix credentials in angular

1f55c7f

art-alexeyenko requested changes Jan 9, 2025

View reviewed changes

address comments

04d8a57

addy-pathania requested a review from art-alexeyenko January 10, 2025 02:02

apathania22 added 2 commits January 10, 2025 11:00

remove only

5cfa5b1

fix headers

ff7ec16

illiakovalenko requested changes Jan 13, 2025

View reviewed changes

address comments 1

586dec0

art-alexeyenko reviewed Jan 13, 2025

View reviewed changes

packages/sitecore-jss-nextjs/src/index.ts Show resolved Hide resolved

apathania22 added 2 commits January 13, 2025 18:04

address review comments 2

b2211a1

update changelog

c74e256

addy-pathania requested review from illiakovalenko and art-alexeyenko January 14, 2025 01:16

illiakovalenko reviewed Jan 14, 2025

View reviewed changes

illiakovalenko requested changes Jan 14, 2025

View reviewed changes

packages/sitecore-jss/src/layout/rest-layout-service.ts Outdated Show resolved Hide resolved

apathania22 added 3 commits January 14, 2025 13:41

fix sitemap stream

7a7164c

fix response type

9427090

fix tests, refactor package-deploy

4afe6c9

addy-pathania requested a review from illiakovalenko January 15, 2025 05:43

apathania22 added 2 commits January 15, 2025 00:45

improvements

7b2bb72

udpate changelog

2600bc3

illiakovalenko reviewed Jan 15, 2025

View reviewed changes

illiakovalenko requested changes Jan 15, 2025

View reviewed changes

illiakovalenko reviewed Jan 15, 2025

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

apathania22 added 3 commits January 15, 2025 09:58

add back comments

fdf1ee1

rebase with dev

6776d42

refactor tests

a39f681

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Axios #2006

Remove Axios #2006

addy-pathania commented Jan 8, 2025 •

edited

Loading

art-alexeyenko left a comment

art-alexeyenko Jan 9, 2025

illiakovalenko left a comment

illiakovalenko Jan 10, 2025

illiakovalenko Jan 14, 2025 •

edited

Loading

addy-pathania Jan 14, 2025

illiakovalenko Jan 14, 2025 •

edited

Loading

illiakovalenko Jan 15, 2025

illiakovalenko Jan 14, 2025 •

edited

Loading

illiakovalenko Jan 15, 2025

illiakovalenko Jan 15, 2025

illiakovalenko left a comment

Remove Axios #2006

Are you sure you want to change the base?

Remove Axios #2006

Conversation

addy-pathania commented Jan 8, 2025 • edited Loading

Description / Motivation

Testing Details

Types of changes

art-alexeyenko left a comment

Choose a reason for hiding this comment

art-alexeyenko Jan 9, 2025

Choose a reason for hiding this comment

illiakovalenko left a comment

Choose a reason for hiding this comment

illiakovalenko Jan 10, 2025

Choose a reason for hiding this comment

illiakovalenko Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

addy-pathania Jan 14, 2025

Choose a reason for hiding this comment

illiakovalenko Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

illiakovalenko Jan 15, 2025

Choose a reason for hiding this comment

illiakovalenko Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

illiakovalenko Jan 15, 2025

Choose a reason for hiding this comment

illiakovalenko Jan 15, 2025

Choose a reason for hiding this comment

illiakovalenko left a comment

Choose a reason for hiding this comment

addy-pathania commented Jan 8, 2025 •

edited

Loading

illiakovalenko Jan 14, 2025 •

edited

Loading

illiakovalenko Jan 14, 2025 •

edited

Loading

illiakovalenko Jan 14, 2025 •

edited

Loading