Skip to content

Commit

Permalink
TODO: fix compile
Browse files Browse the repository at this point in the history
In file included from test/sv2_messages_tests.cpp:2:
In file included from ./node/sv2_messages.h:4:
In file included from ./consensus/validation.h:11:
./primitives/transaction.h:394:44: error: no member named 'GetParams' in 'CDataStream'
        UnserializeTransaction(*this, s, s.GetParams());
                                         ~ ^
./serialize.h:781:7: note: in instantiation of function template specialization 'CMutableTransaction::Unserialize<CDataStream>' requested here
    a.Unserialize(is);
      ^
./streams.h:313:11: note: in instantiation of function template specialization 'Unserialize<CDataStream, CMutableTransaction &>' requested here
        ::Unserialize(*this, obj);
          ^
./node/sv2_messages.h:539:11: note: in instantiation of function template specialization 'CDataStream::operator>><CMutableTransaction &>' requested here
        s >> m_coinbase_tx;
          ^
./serialize.h:781:7: note: in instantiation of function template specialization 'node::Sv2SubmitSolutionMsg::Unserialize<CDataStream>' requested here
    a.Unserialize(is);
      ^
./streams.h:313:11: note: in instantiation of function template specialization 'Unserialize<CDataStream, node::Sv2SubmitSolutionMsg &>' requested here
        ::Unserialize(*this, obj);
          ^
test/sv2_messages_tests.cpp:232:8: note: in instantiation of function template specialization 'CDataStream::operator>><node::Sv2SubmitSolutionMsg &>' requested here
    ss >> submit_solution;
       ^
1 error generated.
  • Loading branch information
Sjors committed Nov 29, 2023
1 parent 33a3c8a commit c148ba4
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/test/sv2_messages_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,7 @@ BOOST_AUTO_TEST_CASE(Sv2SubmitSolution_test)
CDataStream ss(input, SER_NETWORK, PROTOCOL_VERSION);

node::Sv2SubmitSolutionMsg submit_solution;
// TODO: fix after rebase (original: f2dddadf7cf1e029787a588833752081a84e2195)
// error: no member named 'GetParams' in 'CDataStream'
// ss >> submit_solution;
ss >> submit_solution;

// BOOST_CHECK_EQUAL(submit_solution.m_template_id, 2);
// BOOST_CHECK_EQUAL(submit_solution.m_version, 2);
Expand Down

0 comments on commit c148ba4

Please sign in to comment.